Skip to content

fix(android): drop setUnlockedDeviceRequired from rootkey wrapper key #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmaclennan merged 2 commits into from
May 7, 2026
+3 −3
Merged

fix(android): drop setUnlockedDeviceRequired from rootkey wrapper key #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb56d80
fix(android): drop setUnlockedDeviceRequired from rootkey wrapper key
gmaclennan May 6, 2026
07f82e2
docs(android): tighten RootKeyStore comment on dropped unlock-require…
gmaclennan May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/src/main/java/com/comapeo/core/RootKeyStore.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ class RootKeyStore(private val context: Context) {
// attacked by another app on the same device".
.setUserAuthenticationRequired(false)

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
builder.setUnlockedDeviceRequired(true)
}
// Not using setUnlockedDeviceRequired(true): generation fails
// on no-lock devices and disabling the lock later permanently
// invalidates the key — both are identity loss. See PR #57.

val generator = KeyGenerator.getInstance(
KeyProperties.KEY_ALGORITHM_AES,
Expand Down
Loading