Skip to content

docs(breadcrumbs,button,card): update accessibility guidelines#4820

Open
Febakke wants to merge 9 commits into
mainfrom
docs-accessibility-breadcrumbs-button-card
Open

docs(breadcrumbs,button,card): update accessibility guidelines#4820
Febakke wants to merge 9 commits into
mainfrom
docs-accessibility-breadcrumbs-button-card

Conversation

@Febakke
Copy link
Copy Markdown
Member

@Febakke Febakke commented May 4, 2026

Summary

Adding accessibility docs for Breadcrumbs, Button and Card

Need help! ⚠️

Loading button test

As is now:

Using a loader in Button must provide understandable feedback to screen reader users.

If the button shows a loading indicator, consider how the status is communicated (for example with an aria-live region or updated text).

I think this is something many would need help with. What happens if loading fails and gives an error message. Should they use aria-live to tell the user or move focus to the error? How much should we put into this?

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

⚠️ No Changeset found

Latest commit: e305d4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0bf23c3e-897f-47c6-a87d-5ddb9a5fa365

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs-accessibility-breadcrumbs-button-card

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Preview deployments for this pull request:

www - 13. May 2026 - 14:43

@Febakke Febakke marked this pull request as ready for review May 4, 2026 09:09
@mimarz mimarz changed the title Docs accessibility breadcrumbs button card docs(breadcrumbs,button,card): update accessibility guidelines May 4, 2026
@eirikbacker
Copy link
Copy Markdown
Contributor

eirikbacker commented May 13, 2026

A button should not have aria-live, but the button in loading state should have aria-busy="true".
If an error occurs, this works the same way as in forms; an errorsummary should appear and take fokus automatically. When focus is taken automatically, screen readers will both announce it, and be placed in the correct place to further explore what errors occurred :)

A toast or similar is possible, but has more potential accessibility issues than displaying the error in an errorsummary

@mimarz
Copy link
Copy Markdown
Collaborator

mimarz commented May 13, 2026

A button should not have aria-live, but the button in loading state should have aria-busy="true". If an error occurs, this works the same way as in forms; an errorsummary should appear and take fokus automatically. When focus is taken automatically, screen readers will both announce it, and be placed in the correct place to further explore what errors occurred :)

A toast or similar is possible, but has more potential accessibility issues than displaying the error in an errorsummary

I have updated the section about loading buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants