docs(breadcrumbs,button,card): update accessibility guidelines#4820
docs(breadcrumbs,button,card): update accessibility guidelines#4820Febakke wants to merge 9 commits into
Conversation
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployments for this pull request: www - |
|
A button should not have A toast or similar is possible, but has more potential accessibility issues than displaying the error in an errorsummary |
I have updated the section about loading buttons. |
Summary
Adding accessibility docs for Breadcrumbs, Button and Card
Need help!⚠️
Loading button test
As is now:
I think this is something many would need help with. What happens if loading fails and gives an error message. Should they use aria-live to tell the user or move focus to the error? How much should we put into this?