Skip to content

docs: clickdelegatefor#4544

Merged
Barsnes merged 7 commits intomainfrom
docs/clickdelegate
Feb 27, 2026
Merged

docs: clickdelegatefor#4544
Barsnes merged 7 commits intomainfrom
docs/clickdelegate

Conversation

@Barsnes
Copy link
Member

@Barsnes Barsnes commented Feb 25, 2026

Summary

Checks

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

⚠️ No Changeset found

Latest commit: 70a54d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Barsnes Barsnes marked this pull request as ready for review February 25, 2026 09:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Preview deployments for this pull request:

www - 27. Feb 2026 - 10:25

Co-authored-by: Michael Marszalek <mimarz@gmail.com>
@oddvernes
Copy link
Collaborator

oddvernes commented Feb 25, 2026

Should include somewhere that the element with data-clickdelegatefor must be a parent of the id-referenced target

Oh wait it must not be a child, it can be some other random element outside as well as long as it is not interactive itself 🤔

…efor.mdx

Co-authored-by: Michael Marszalek <mimarz@gmail.com>
@oddvernes
Copy link
Collaborator

Should mention that idref target recieves class .\:click-delegate-hover so readers know they can style this

@Barsnes
Copy link
Member Author

Barsnes commented Feb 25, 2026

Should mention that idref target recieves class .\:click-delegate-hover so readers know they can style this

yes, probably good to mention :)

@oddvernes
Copy link
Collaborator

and then maybe also that the following elements as children of data-clickdelegatefor are still clickable
a,button,label,input,select,textarea,details,dialog,[role="button"],[popover],[contenteditable]

@eirikbacker
Copy link
Contributor

and then maybe also that the following elements as children of data-clickdelegatefor are still clickable a,button,label,input,select,textarea,details,dialog,[role="button"],[popover],[contenteditable]

Good point :) I think you can just mention "interactive or editable elements"? 🤔 ☺️

Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks got to me!

Barsnes and others added 3 commits February 27, 2026 10:14
@Barsnes Barsnes requested a review from oddvernes February 27, 2026 10:22
@Barsnes Barsnes merged commit 05e5e8d into main Feb 27, 2026
7 checks passed
@Barsnes Barsnes deleted the docs/clickdelegate branch February 27, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants