Skip to content

docs: new getting started in code#4531

Open
mimarz wants to merge 16 commits intomainfrom
docs-new-getting-started-code
Open

docs: new getting started in code#4531
mimarz wants to merge 16 commits intomainfrom
docs-new-getting-started-code

Conversation

@mimarz
Copy link
Collaborator

@mimarz mimarz commented Feb 23, 2026

Update getting started in code with web package and trying to shorten it down abit to reduce duplication.

  • Added redirects for react and other-framework pages to new setup page.
  • Saving english translation for last until we finished feedback and structure.
  • Kept old files for now, will delete afterwards.

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2026

⚠️ No Changeset found

Latest commit: 26b08f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

Preview deployments for this pull request:

www - 27. Feb 2026 - 09:04

@mimarz mimarz force-pushed the docs-new-getting-started-code branch 2 times, most recently from 8ded1d0 to 2fb976d Compare February 23, 2026 13:37
@mimarz mimarz marked this pull request as ready for review February 23, 2026 13:57
@eirikbacker
Copy link
Contributor

Nice start, like the consolidation 🤗
Should we place "import CSS" and "import JS" before font? I think font and icons should be last, since these are "we use Aksel and Inter, but you can use anything" and make it like tabs? "Use default font" "Use custom font" so we do not confuse anyone with the need for font-feature-settings: "cv05" 1; in their own font etc.

Also, I'd like to maybe merge it even more, with React as a tab on each relevant step, or as a Radio-selection in the start. For instance, look at the React tab in step 2 in https://design.mattilsynet.no/?path=/docs/designsystem-introduksjon--docs - the use of a "use client" file with the @dirdir/designsystemet-web is super important, so I think we should make making this prominent, and explained for React users ☺️

Same with Tailwind as seen in step 3 here https://design.mattilsynet.no/?path=/docs/designsystem-introduksjon--docs ☺️

@mimarz
Copy link
Collaborator Author

mimarz commented Feb 24, 2026

Nice start, like the consolidation 🤗 Should we place "import CSS" and "import JS" before font? I think font and icons should be last, since these are "we use Aksel and Inter, but you can use anything" and make it like tabs? "Use default font" "Use custom font" so we do not confuse anyone with the need for font-feature-settings: "cv05" 1; in their own font etc.

Also, I'd like to maybe merge it even more, with React as a tab on each relevant step, or as a Radio-selection in the start. For instance, look at the React tab in step 2 in https://design.mattilsynet.no/?path=/docs/designsystem-introduksjon--docs - the use of a "use client" file with the @dirdir/designsystemet-web is super important, so I think we should make making this prominent, and explained for React users ☺️

Same with Tailwind as seen in step 3 here https://design.mattilsynet.no/?path=/docs/designsystem-introduksjon--docs ☺️

Good point about the Font! Thinking about it, we should actually have a snippet for using the --ds-font-family variable instead of "Inter".

I'll shuffle some stuff around based on feedback, forgot about the "use client"!

@mimarz mimarz force-pushed the docs-new-getting-started-code branch from 2fb976d to 0aa13f6 Compare February 24, 2026 07:22
@mimarz
Copy link
Collaborator Author

mimarz commented Feb 24, 2026

Ta en titt igjen nå :) @eirikbacker

Kunne tenkt meg en global switch for valgt dev språk, men det får bli i egen PR da vi trenger det andre plasser og.

@eirikbacker
Copy link
Contributor

Ta en titt igjen nå :) @eirikbacker

Kunne tenkt meg en global switch for valgt dev språk, men det får bli i egen PR da vi trenger det andre plasser og.

Enig om global switch, men MVP ^^

Teksten "Ønsker du å bruke @digdir/designsystemet-web i React må du legge til use client øverst i filen din." er ikke helt rett; man må bruke "@digdir/designsystemet-web", dog, pr. nå lastes den automatisk av de relevante komponentene i React.

Hmmm. dette er kanskje mer SSR-relevant. Vi kan vente med å skrive om @digdir/designsystemet-web i react, også heller tenke litt på hvordan SSR/RSC kan bli etterhvert

mimarz and others added 8 commits February 26, 2026 12:07
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

norwegian version looks good to me 🚀

@mimarz
Copy link
Collaborator Author

mimarz commented Feb 27, 2026

norwegian version looks good to me 🚀

added english version now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants