Conversation
|
|
Preview deployments for this pull request: www - |
8ded1d0 to
2fb976d
Compare
|
Nice start, like the consolidation 🤗 Also, I'd like to maybe merge it even more, with React as a tab on each relevant step, or as a Radio-selection in the start. For instance, look at the React tab in step 2 in https://design.mattilsynet.no/?path=/docs/designsystem-introduksjon--docs - the use of a Same with Tailwind as seen in step 3 here https://design.mattilsynet.no/?path=/docs/designsystem-introduksjon--docs |
Good point about the Font! Thinking about it, we should actually have a snippet for using the I'll shuffle some stuff around based on feedback, forgot about the "use client"! |
2fb976d to
0aa13f6
Compare
|
Ta en titt igjen nå :) @eirikbacker Kunne tenkt meg en global switch for valgt dev språk, men det får bli i egen PR da vi trenger det andre plasser og. |
Enig om global switch, men MVP ^^ Teksten "Ønsker du å bruke @digdir/designsystemet-web i React må du legge til use client øverst i filen din." er ikke helt rett; man må bruke "@digdir/designsystemet-web", dog, pr. nå lastes den automatisk av de relevante komponentene i React. Hmmm. dette er kanskje mer SSR-relevant. Vi kan vente med å skrive om @digdir/designsystemet-web i react, også heller tenke litt på hvordan SSR/RSC kan bli etterhvert |
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Barsnes
left a comment
There was a problem hiding this comment.
norwegian version looks good to me 🚀
added english version now :) |
Update getting started in code with web package and trying to shorten it down abit to reduce duplication.