Conversation
🦋 Changeset detectedLatest commit: fccaae4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: storybook - themebuilder - www - |
|
@oddvernes how strange. It scales fine in my Firefox (147.0.3) |
|
Weird, Im on same firefox, macbook. But its seems to mainly be noticeable at pretty high zoom like 200% (with cmd +) and above so it is not as bad as safari. perhaps it is flex-shrink or something |
|
After some discussion at a daily, it was decided that the @eirikbacker suggested setting font-size to |
Unfortunately that doesn't work. If you set We did fix this downstream using the If it varies too much, we could potentially calculate the magic value in the theme builder when we add official support for using other fonts 🤔 |
|
Ah, of course I forgot to test in safari 🤦... For ex variation: The most extreme difference in my small sample of test fonts is between by the way there is one other fix, but it requires a registered custom property Technically we already have one with the needed type in avatar-stack (--captured-length). It could be moved to base.css and used for this as well since they are reusable. 🤔 |
…effect, replace with height/width where it had to fix scaling in Safari
94a0296 to
d3df76c
Compare
e2fc91f to
a706c95
Compare
|
I am going over these. Spinner fixed (using width/height), fixed badge, tabs, tag, all should be good now 👍 |
|
This also fixes a bug where |



Summary
Changes icon sizing css from using
font-size, which breaks scaling when zooming in Safari, to using height and widthFixes #4038
Checks
pnpm changesetif relevant)