This repository was archived by the owner on Jun 11, 2019. It is now read-only.
Logout handling without logoutRedirectUri and passAlongData optional#136
Open
Logout handling without logoutRedirectUri and passAlongData optional#136
Conversation
…outRedirectUri is configured, where it's not, and where cookie is seemingly already deleted
…se to service with userData and redirect to configured logoutRedirectUri
…ut response is returned from service
…y variable i DatabaseCookieStorage. Tested additional data won't be added or cause problems if pass_along_data is not present
… no configured logoutRedirectUri exist
Current coverage is 62.48% (diff: 29.09%)@@ master #136 diff @@
==========================================
Files 32 32
Lines 1004 1037 +33
Methods 0 0
Messages 0 0
Branches 66 77 +11
==========================================
+ Hits 642 648 +6
- Misses 335 356 +21
- Partials 27 33 +6
|
… where logout request comes directly from server
…d handle logout requests directly from server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle logout where logoutRedirectUri is not present. Made passAlongData optional in configuration and made sure additional userData won't get added if not present.