Skip to content

Add untouched shell state to skip kill confirmation#61

Draft
nedtwigg wants to merge 3 commits into
mainfrom
codex/add-untouched-shell-state
Draft

Add untouched shell state to skip kill confirmation#61
nedtwigg wants to merge 3 commits into
mainfrom
codex/add-untouched-shell-state

Conversation

@nedtwigg
Copy link
Copy Markdown
Member

Summary

  • Track an internal untouched flag for newly spawned shells and clear it on first user-originated PTY input.
  • Skip kill confirmation for untouched panes and doors, while preserving the existing confirmation flow for touched sessions.
  • Persist the flag through save, resume, and restore, with legacy snapshots defaulting conservatively to false.
  • Update the layout and transport specs to document the new state and persistence shape.

Testing

  • Added unit coverage for untouched state tracking, save/restore/reconnect seeding, and legacy snapshot normalization.
  • Added keyboard-path tests to verify untouched kills bypass confirmation while touched sessions still prompt.
  • Ran the lib, website, and VS Code build/test flows successfully.

nedtwigg and others added 2 commits May 9, 2026 21:22
Replaces mutually exclusive `confirmKill` / `killImmediately` booleans
with `afterRestore: 'confirm-kill' | 'kill-immediately'`, removing the
parallel option-object construction at the call site.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 10, 2026

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 13a921b
Status: ✅  Deploy successful!
Preview URL: https://9d9caba5.mouseterm.pages.dev
Branch Preview URL: https://codex-add-untouched-shell-st.mouseterm.pages.dev

View logs

Shell-selection dropdown (standalone) and Select Shell command (VS Code)
now send mouseterm:newTerminal with replaceUntouched and announce. When
the focused pane or door is untouched, Wall swaps the new session into
the same dockview slot and disposes the old one without kill
confirmation; otherwise the request falls through to the regular spawn
path. A short pane-anchored notice ("Switched to zsh" / "Opened bash")
provides feedback. VS Code post is retried briefly so it works right
after focusing the view.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant