Set 20-minute timeout for all CMake-based regression tests#8848
Open
tautschnig wants to merge 4 commits intodiffblue:developfrom
Open
Set 20-minute timeout for all CMake-based regression tests#8848tautschnig wants to merge 4 commits intodiffblue:developfrom
tautschnig wants to merge 4 commits intodiffblue:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a per-test timeout to the regression test infrastructure to prevent CI hangs from long-running tests.
Changes:
- Enforce a 20-minute CTest timeout for CMake-registered regression tests.
- Add an optional
-t/TESTPL_TIMEOUTtimeout toregression/test.pl, implemented viafork+alarm+ process-group kill. - Update the test runner call chain to pass the timeout through to execution.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| regression/test.pl | Adds a per-test timeout option and enforces it by killing the test process group on timeout. |
| regression/CMakeLists.txt | Adds TIMEOUT 1200 to CTest properties for regression tests. |
| regression/libcprover-cpp/CMakeLists.txt | Adds TIMEOUT 1200 to CTest properties for regression tests in libcprover-cpp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tautschnig
force-pushed
the
test-timeout
branch
2 times, most recently
from
560c68e to
be53558
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8848 +/- ##
========================================
Coverage 80.01% 80.01%
========================================
Files 1700 1700
Lines 188338 188338
Branches 73 73
========================================
+ Hits 150695 150696 +1
+ Misses 37643 37642 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tautschnig
force-pushed
the
test-timeout
branch
4 times, most recently
from
7291566 to
0614468
Compare
Add TIMEOUT 1200 to the set_tests_properties call in both copies of the add_test_pl_profile macro (regression/CMakeLists.txt and regression/libcprover-cpp/CMakeLists.txt). This ensures CTest will kill and report as failed any regression test that exceeds 20 minutes, preventing CI jobs from hanging indefinitely on tests that time out. Co-authored-by: Kiro (autonomous agent) <kiro-agent@users.noreply.github.com>
Fork the test command into a new process group and use alarm() to enforce an optional per-test timeout. When the timeout fires, kill the entire process group with SIGKILL and report the test as failed with a TIMEOUT marker. The timeout can be set via -t <secs> on the command line or via the TESTPL_TIMEOUT environment variable (command line takes precedence). Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
These two test suites regularly exceed the default 1200-second timeout on macOS CI runners. Set a 2700-second (45-minute) timeout for jbmc-symex-driven-lazy-loading-CORE and jbmc-strings-symex-driven-lazy-loading-CORE. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
contracts-dfcc-CORE and book-examples-cprover-smt2-CORE exceeded the default 1200-second timeout on macOS 14 ARM runners. Set 3600-second (1-hour) timeouts for these suites. Also bump jbmc symex-driven lazy-loading timeouts from 2700 to 3600 seconds as they still timed out at the previous limit. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TIMEOUT 1200 to the set_tests_properties call in both copies of the add_test_pl_profile macro (regression/CMakeLists.txt and regression/libcprover-cpp/CMakeLists.txt). This ensures CTest will kill and report as failed any regression test that exceeds 20 minutes, preventing CI jobs from hanging indefinitely on tests that time out.