Avoid unnecessary copy in convert_method.cpp

hannes-steffenhagen-diffblue · hannes-steffenhagen-diffblue · commit 2883bb31373f · 2020-06-29T17:57:33.000+01:00
Without the &amp; we’re copying the items we’re iterating over, which is unnecessary
in this case.
diff --git a/jbmc/unit/java_bytecode/java_bytecode_convert_method/convert_method.cpp b/jbmc/unit/java_bytecode/java_bytecode_convert_method/convert_method.cpp
@@ -938,7 +938,7 @@ TEST_CASE(
   other_param.type() = java_lang_object_type();
   java_method_typet::parameterst parameters{
     this_param, ref_to_inner, other_param};
-  for(const auto param : parameters)
+  for(const auto &param : parameters)
   {
     REQUIRE(param.get_identifier().empty());
     REQUIRE(param.get_base_name().empty());

Original file line number	Diff line number	Diff line change
`@@ -938,7 +938,7 @@ TEST_CASE(`
`938`	`938`	`other_param.type() = java_lang_object_type();`
`939`	`939`	`java_method_typet::parameterst parameters{`
`940`	`940`	`this_param, ref_to_inner, other_param};`
`941`		`- for(const auto param : parameters)`
	`941`	`+ for(const auto &param : parameters)`
`942`	`942`	`{`
`943`	`943`	`REQUIRE(param.get_identifier().empty());`
`944`	`944`	`REQUIRE(param.get_base_name().empty());`