Avoid unnecessary copies in add_java_array_types.cpp

hannes-steffenhagen-diffblue · hannes-steffenhagen-diffblue · commit adc0eba5d1d5 · 2020-06-29T17:57:33.000+01:00
Without the &amp; we’re copying the items we’re iterating over, which is unnecessary
in this case.
diff --git a/jbmc/unit/java_bytecode/java_bytecode_convert_class/add_java_array_types.cpp b/jbmc/unit/java_bytecode/java_bytecode_convert_class/add_java_array_types.cpp
@@ -27,7 +27,7 @@ TEST_CASE("Add array types", "[core]")
 
   SECTION("Array class symbol exists")
   {
-    for(const std::string array_type : array_types)
+    for(const std::string &array_type : array_types)
     {
       const auto array_type_symbol = require_symbol::require_symbol_exists(
         symbol_table, "java::array[" + array_type + "]");
@@ -38,7 +38,7 @@ TEST_CASE("Add array types", "[core]")
   }
   SECTION("Array clone method exists")
   {
-    for(const std::string array_type : array_types)
+    for(const std::string &array_type : array_types)
     {
       const auto array_type_symbol = require_symbol::require_symbol_exists(
         symbol_table,

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ TEST_CASE("Add array types", "[core]")`
`27`	`27`
`28`	`28`	`SECTION("Array class symbol exists")`
`29`	`29`	`{`
`30`		`- for(const std::string array_type : array_types)`
	`30`	`+ for(const std::string &array_type : array_types)`
`31`	`31`	`{`
`32`	`32`	`const auto array_type_symbol = require_symbol::require_symbol_exists(`
`33`	`33`	`symbol_table, "java::array[" + array_type + "]");`
`@@ -38,7 +38,7 @@ TEST_CASE("Add array types", "[core]")`
`38`	`38`	`}`
`39`	`39`	`SECTION("Array clone method exists")`
`40`	`40`	`{`
`41`		`- for(const std::string array_type : array_types)`
	`41`	`+ for(const std::string &array_type : array_types)`
`42`	`42`	`{`
`43`	`43`	`const auto array_type_symbol = require_symbol::require_symbol_exists(`
`44`	`44`	`symbol_table,`