Skip to content

Animate turn on on device reboot #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
diegoasanch wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Animate turn on on device reboot #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/RGBLed.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,18 @@ class RGBLed {
uint8_t b = this->settings.getRgbBlue();
this->color = { r, g, b };

if (this->shouldTurnOn())
this->turnOnAnimated();
else
this->turnOffAnimated();

this->updateLedDisplayValues();
}

bool shouldTurnOn() {
return !isOn && this->targetBrightness != 0;
}

void run() {
this->red.run();
this->green.run();
Expand Down
2 changes: 1 addition & 1 deletion src/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ namespace pins {
}

namespace device {
const String VERSION = "v1.2.0-rc1";
const String VERSION = "v1.2.0-rc5";
}
2 changes: 1 addition & 1 deletion src/src.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void setup() {
digitalWrite(LED_BUILTIN, LOW);

rgb.startFromStorage();
rgb.run();
// rgb.run();

// TODO: activate Serial with env
Serial.begin(115200);
Expand Down