Fix accented input matching and false misstrokes with Plover#276
Open
mekalika wants to merge 1 commit into
Open
Fix accented input matching and false misstrokes with Plover#276mekalika wants to merge 1 commit into
mekalika wants to merge 1 commit into
Conversation
Normalize lesson and typed text to NFC so composed/decomposed accents compare equal. Normalize textarea input so buffer slicing matches matchSplitText output. Stop appending debounced buffer intermediates so strokeAccuracy does not treat multi-event OS input as extra attempts. Adds matchSplitText tests for NFC/NFD José. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
évse+ combining acute), so matching looked wrong compared to paste.inputevents in one debounced batch could still produce false misstrokes:strokeAccuracytreats same-length adjacent snapshots as extra attempts.Changes
matchSplitText: NormalizeexpectedandactualTextto NFC before comparing; tests for José NFC/NFD.App.tsx: Normalize textarea value to NFC so buffer/state aligns withmatchSplitTextprefixes; stop pushingbuffer.slice(0, -1)into phrase attempts so one batch stays one steno stroke for stroke counting.Testing
pnpm exec vitest run src/utils/matchSplitText.test.ts src/utils/strokeAccuracy.test.tsFixes #275