Skip to content

fix: code review fixes for feat 优化文档 增加css使用#42

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/code-review-latest-commit
Draft

fix: code review fixes for feat 优化文档 增加css使用#42
Copilot wants to merge 2 commits intomainfrom
copilot/code-review-latest-commit

Conversation

Copy link

Copilot AI commented Feb 28, 2026

Code review of commit 2714f97 (feat: 优化文档,增加css使用) identified duplicated utility logic, a typo in an exported function name, a dead/malformed regex, stale commented-out code, and a debug trigger comment.

Changes

  • Extract shared utility: convertCssVarFormat was defined identically in both compiler files; moved to packages/website-build/src/utils/index.ts and imported where needed
  • Fix function name typo: genCompnentsCSSVariablesMdgenComponentsCSSVariablesMd in compile-components-css-variables-md.ts and its caller compile-doc-md.ts
  • Remove dead regex: /\$\(,/ in regexpList matches the literal string $(, — unreachable and unintentional given the preceding /\$(.+)/ already covers the general $var case
  • Remove dead commented-out code: Cleaned up 3 alternative implementations left in comments inside compile-components-css-variables-md.ts
  • Remove debug trigger comment: // 触发 main 分支 docs 更新 23 in example/app.ts — triggering CI via comment bumps is fragile and should not persist in source

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/didi/mpx-cube-ui/commits/2714f9749b4a549b947e08b4fd20bcefe74b3156
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…po, remove dead code

Co-authored-by: CommanderXL <9695264+CommanderXL@users.noreply.github.com>
Copilot AI changed the title [WIP] Review latest code submission for improvements fix: code review fixes for feat 优化文档 增加css使用 Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants