Pulling feat/plasmid-filter into develop#1174
Open
github-actions[bot] wants to merge 5 commits intodevelopfrom
Open
Pulling feat/plasmid-filter into develop#1174github-actions[bot] wants to merge 5 commits intodevelopfrom
github-actions[bot] wants to merge 5 commits intodevelopfrom
Conversation
…ureStrainCatalogSearchGraphql` The filter configuration logic in `useConfigureStrainCatalogSearchGraphql` has been simplified by removing unnecessary lenses and pipes, and by adding comments to improve readability. The code now directly uses the graphqlFilterLens to get the filter config that matches `value`, and adds any other valid search parameters to the query filter. The initial values are then modified with the selected filters and other search parameters.
The search bar component was added to the plasmid catalog page to allow users to search for plasmids.
The new SearchBarPlasmid component was created, which includes a FilterDropdown, SearchBox, and AppBarHelp. This component will be used in the catalog page to search for plasmids.
The FilterDropdown component now uses the options prop to render menu items, replacing the hardcoded items array. The key prop in MenuItem is now set to option.value instead of uuid4().
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.