Update sample plugin (sdk 3.4.1) #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update project version to 3.1.0 (minor bump) - update dicoogle-sdk to 3.4.1 (latest SDK) - update build dependency maven-compiler-plugin to the latest version - update license-maven-plugin to v2.9
- update actions/checkout to v4 - update actions/setup-java to v4 - use temurin for the JDK distro
- URIs always use forward slashes regardless of platform OS
- better practice
- Update URLs - Ask user to have Java 8 or 11 installed - Suggest to use `mvn package` instead of `mvn install` - Update the resulting jar file name - Refer to Dicoogle learning pack - Suggest adding dicoogle-plugin-sample to the list of DIM providers - Tweak formatting a bit
- scheme should not include the "://" part
- do not use raw types - save byte arrays instead of dangling output streams
- Instead of hello world, provide Dicoogle Health Check, the tutorial webplugin - use parcel to build the plugin
bastiao
approved these changes
Mar 11, 2025
Collaborator
Author
|
This repo is a good candidate for transfer to the dicoogle organization, by the way. We can update the references to the repository afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RSIQueryJsonWebService, extendRSIWebResourceinsteadRSIStorageRSIStorage