Skip to content

change some old import#8

Open
geant44 wants to merge 1 commit into
dicompyler:masterfrom
geant44:patch-1
Open

change some old import#8
geant44 wants to merge 1 commit into
dicompyler:masterfrom
geant44:patch-1

Conversation

@geant44

@geant44 geant44 commented Feb 24, 2018

Copy link
Copy Markdown

change pub and Queue module

change pub and Queue module
@bastula

bastula commented Feb 26, 2018

Copy link
Copy Markdown
Member

Is this so that it works on Python 3?

@bastula bastula requested review from StephenTerry and removed request for StephenTerry February 26, 2018 04:08
@geant44

geant44 commented Feb 27, 2018 via email

Copy link
Copy Markdown
Author

@StephenTerry

Copy link
Copy Markdown
Contributor

This plugin requires Python 3+ and wxPython Phoenix 4+. Are you trying to run it on Python 2.7?

@geant44

geant44 commented Mar 2, 2018 via email

Copy link
Copy Markdown
Author

@bastula

bastula commented Mar 2, 2018 via email

Copy link
Copy Markdown
Member

@geant44

geant44 commented Mar 5, 2018 via email

Copy link
Copy Markdown
Author

@bastula

bastula commented Mar 5, 2018

Copy link
Copy Markdown
Member

Once we have the version updated, there won't be any need to maintain a separate 2.7 codebase for plugins. If you still need to get a copy of the old version of the plugin prior to the Python 3 change, you can browse the repo here: https://github.com/dicompyler/dicompyler-plugins/blob/946eb2c332cfd1c800edb080ecddccb85b2947e9/plugins/plansum/plansum.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants