Skip to content

Comments

submitting assignment 3#3

Open
dianayangs wants to merge 2 commits intomainfrom
assignment-3
Open

submitting assignment 3#3
dianayangs wants to merge 2 commits intomainfrom
assignment-3

Conversation

@dianayangs
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

changes to assignment 3

What did you learn from the changes you have made?

I learned how to cluster and bootstrap using python

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

not necessarily, I was comparing it to how I would normally do this with the R language

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

had troubles with running the last bootstrap chunk since I have minor spelling errors (with american vs canadian spelling) but I combed through my code and found my mistakes

How were these changes tested?

I ran the chunk until no errors occurred

A reference to a related issue in your repository (if applicable)

Checklist

  • [ X] I can confirm that my changes are working as intended

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of review changes requested.

  1. Question 2: Could you please mention one pair of features that show visible clustering between wines.
  2. Question 5: The bootstrap mean is to be calculated from the original dataset instead of bootstrap samples. Its related to this line of code:
    print(f"Mean of Color Intensity: {mean_color_intensity}")

You can do:
mean_color_intensity = wine_df['color_intensity'].mean()

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review corrections done successfully. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants