feat: allow sharing dialog to only show data sharing and hide metadat… #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 Deployed on https://pr-1709--dhis2-ui.netlify.app |
kabaros
reviewed
Dec 22, 2025
| dataSharing | ||
| ? 'endWrapper endWrapperData' | ||
| : 'endWrapper endWrapperMetadata' | ||
| dataSharing && metadataSharing |
Collaborator
There was a problem hiding this comment.
minor(if it makes sense to you): maybe all of these dataSharing && metadataSharing combinations can be stored in a variable to make it less verbose and semantic .. something like showAllSharingModes or even showDataAndMetadataSharing (or the other way, showMetaDataOnly)
kabaros
approved these changes
Dec 22, 2025
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR we want to change the sharing dialog so that it can be used for only data sharing, and no metadata sharing.
This will be used in the new maintanace app, for program stages sharing setting.
Checklist
Screenshots