fix: apps with long name don't have icons displayed in list#60
Open
ibrahim8955 wants to merge 1 commit intodhis2:mainfrom
Open
fix: apps with long name don't have icons displayed in list#60ibrahim8955 wants to merge 1 commit intodhis2:mainfrom
ibrahim8955 wants to merge 1 commit intodhis2:mainfrom
Conversation
|
kabaros
requested changes
Feb 16, 2026
Collaborator
There was a problem hiding this comment.
Thanks for the nice solution (and the nice touch of adding a title for accessbility, and considering menu management app 🙏🏿 ) - one thing is that this doesn't seem to work with shortcuts:
- It takes a long shortcut down to the next row
- The chevron
>is not aligned with the texts anymore (for all shortcuts, even if they're not long)
Could you look at these please - I think adding the truncate class to the parent span (next to the title class) works well (and no need for the extra span)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed app with long name don't have icons displayed in list