Skip to content

feat: API endpoint cache#22748

Closed
netroms wants to merge 9 commits intomasterfrom
DHIS2-20736_POC
Closed

feat: API endpoint cache#22748
netroms wants to merge 9 commits intomasterfrom
DHIS2-20736_POC

Conversation

@netroms
Copy link
Copy Markdown
Contributor

@netroms netroms commented Jan 13, 2026

PR: Entity-Type Granularity for ETag Caching

Summary

  • Implements entity-type-specific version counters for ETag caching instead of a single global version
  • Changes to one entity type (e.g., OrganisationUnit) no longer invalidate caches for other entity types (e.g., DataSet)
  • Redis keys: etag:version:OrganisationUnit, etag:version:DataSet, etc.

Test plan

  • Unit tests pass (19 tests in ConditionalETagServiceTest)
  • Verify /api/organisationUnits returns 304 when only DataSet changes
  • Verify /api/organisationUnits returns 200 with new data when OrganisationUnit changes
  • Test in clustered environment with Redis pub/sub

Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

netroms added 8 commits March 6, 2026 18:37
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
ETagCacheDisabledCondition

Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 6, 2026

@netroms netroms closed this Mar 16, 2026
@netroms netroms deleted the DHIS2-20736_POC branch March 16, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant