Skip to content

Conversation

@amcgee
Copy link
Member

@amcgee amcgee commented Nov 27, 2025

Implements LIBS-802 and LIBS-400


Key features

  1. Add support for PAT authentication by passing an apiToken parameter to the data engine config
  2. Automatically generate, cache, and follow query aliases in the case where the network throws a 414 URI Too Long error

Checklist

  • Have written Documentation
    • TODO
  • Has tests coverage
    • Added unit tests for the new LRUCache class, but have not yet implemented integration tests

Known issues

  • The API token passed to DataEngine might be exposed to downstream consumers with useConfig. This is likely OK as it is most often going to be used in non-React contexts (server scripts) and if a malicious developer really wanted to snoop on this token they could even if we didn't pass it through in Context. However, we could decide to obfuscate / hide this parameter from downstream consumers and only use it for the data service...
  • Creating and following query aliases requires multiple network round-trips
  • Detecting expired / evicted query aliases will be brittle, as the only indication we have is a 404 with a specific error message. We should add server-side error coding.
  • We don't currently have a way to disable using query aliases... it might be a good idea to implement it behind a default-on feature flag.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
4 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants