fix(lib-build): handle .jsx extensions in lib builds #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KaiVandivier
commented
Jun 16, 2025
| @@ -1,5 +1,16 @@ | |||
| const extensionPattern = /\.[jt]sx?$/ | |||
| const normalizeExtension = (ext) => ext.replace(extensionPattern, '.js') | |||
| const extensionPattern = /\.([jt])sx?$/ | |||
Contributor
Author
There was a problem hiding this comment.
This regex is also used in the src/lib/compiler/compile.js file; I made sure this small change doesn't affect its usage there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBS-772
I believe a suitable fix is just to allow
.jsxfiles in the build output (although the JSX itself is still transpiled); I tested and made sure libs with.jsxfiles work when consumed by both apps using CRA and ViteI tested this change out locally by renaming some the files in the App Adapter lib in the repo, building it (
yarn build:adapter), then running the simple example app (yarn start:example)Before:
ConnectedHeaderBar.jsx'./ConnectedHeaderBar.jsx'After:
ConnectedBar.jsx'./ConnectedHeaderBar.jsx'ConnectedHeaderBar.tsx'./ConnectedHeaderBar'