Skip to content

fix: add headers to avoid faulty redirects to global shell #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaiVandivier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add headers to avoid faulty redirects to global shell #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pwa/src/service-worker/set-up-service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,15 @@ export function setUpServiceWorker() {
// Above, the index entry had the redirect param added:
const indexUrl = process.env.PUBLIC_URL + '/index.html?redirect=false'
const navigationRouteHandler = ({ request }) => {
return fetch(request)
let requestToUse = request
// If in an iframe, set custom header to let the backend know not to
// redirect this request to the global shell
if (request.destination === 'iframe') {
const newHeaders = new Headers(request.headers)
newHeaders.append('X-Requested-With', 'iframe')
requestToUse = new Request(request, { headers: newHeaders })
}
return fetch(requestToUse)
.then((response) => {
if (response.type === 'opaqueredirect' || !response.ok) {
// It's sending a redirect to the login page,
Expand Down
Loading