bugfix: adjust the level of the root when deleting nodes#57
Closed
tyrzhang wants to merge 2 commits intodhconnelly:masterfrom
Closed
bugfix: adjust the level of the root when deleting nodes#57tyrzhang wants to merge 2 commits intodhconnelly:masterfrom
tyrzhang wants to merge 2 commits intodhconnelly:masterfrom
Conversation
Owner
|
thank you for the contribution! would you mind splitting the new code that implements Stringer into a separate PR? |
97c918f to
78df826
Compare
Owner
|
fixed the lint issue and rebased your PR, sorry for the trouble |
Owner
|
sorry, should have merged master instead of rebased, you'll have to re-force push |
Author
|
ok, I'll separate a new PR for the Stringer implements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix: adjust the level of the root when deleting nodes
when the tree is deep, and deleting nodes, will cause the issue.
the tree could be like this: one obj but 3 levels depth.
so we need to merge the root in loop, instead of once.