Refresh support#1225
Closed
djm181 wants to merge 4 commits intodgreif:mainfrom
Closed
Conversation
Contributor
Author
|
@dgreif - another one for you - this time not a breaking change ;) |
# Conflicts: # packages/ring-client-api/api.ts
Contributor
Author
|
@dgreif - any thoughts on this PR? |
Owner
|
I haven't had a chance to review this in depth yet. Will take a look in the next few weeks |
Contributor
|
This seems like a great addition, watching ... |
Owner
|
@djm181 it's been a while! I haven't heard much need for refresh support over the past few years, so I'm going to close this as not need. Really appreciate the exploration though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
RingAPI::refresh()which will allow all the locations and cameras to be reloaded.This keeps the existing push receiver and just updates the map it uses to send out notifications. Additionally this adds a blanked
onNewNotificationsubject to theRingApiso that a client can receive dings from cameras without the need to resubscribe to all the cameras after a refresh.