Skip to content

Conversation

@matthewmcneely
Copy link
Contributor

@matthewmcneely matthewmcneely commented Jan 21, 2026

Description

This PR updates the schema view and editing functionality to properly display float32vectors indexed with the hnsw tokenizer. Support for creating and changing predicates indexed this way is still only supported in the Bulk Edit dialog, but this PR ensures that at least you can view them.

Additionally, this PR fixes a problem where existing hnsw-indexed predicates would not display their full tokenizer options in Bulk Edit dialog, possibly leading to indexes being deleted for affected predicates.

Checklist

  • Code compiles correctly and linting passes locally

Copy link
Contributor

@raphael-istari raphael-istari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested different indexes from bulkedit and API with all parameters and no parameters.
functionality is ok.

[]index should appear checked when we have the index.
Probably have to change SchemaPredicateForm.js with

predicate.index =
!!predicate.index ||
(predicate.type === 'float32vector' &&
Array.isArray(predicate.index_specs) &&
predicate.index_specs.length > 0)

Copy link
Contributor

@raphael-istari raphael-istari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@raphael-istari raphael-istari merged commit ce230d4 into main Jan 22, 2026
6 checks passed
@raphael-istari raphael-istari deleted the matthewmcneely/properly-display-vector-indexes branch January 22, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants