add validation for directive arguments inside Type Definition#4
add validation for directive arguments inside Type Definition#4minhaj-shakeel wants to merge 9 commits intomainfrom
Conversation
Added a function that translates map[string]interface{} to ast.Value
Add validation for directive location. A directive can not be used at any location. It must be used only at location on which it has been defined for.
59e59a8 to
6b4a785
Compare
|
@minhaj-shakeel Hi! I've started maintaining vektah/gqlparser and I would love to merge your improvements upstream. I know you are all dealing with quite a bit, but if I can help in any way, please don't hesitate to let me know. |
|
Hello again! I would love to help merge the improvements in this fork into the upstream version. I would really appreciate it if you can open PRs there if you get a chance. I made a draft mega-giant-one just to remember what all the DGraph changes were: vektah#179 People who contributed to that are: |
|
|
|
hey, is that PR dead ? |
|
Hey, @ryanfoxtyler I took a look but wasn't familiar enough with the dgraph codebase to get it to use the upstream gqlparser. |
Fixes GRAPHQL-671.
This PR adds argument validation in the directive validation applied to the fields inside a given type.
For example earlier
didn't return error while validation of type but now it does.