fix: restore parent ol numId after nested list closes#58
Open
arthrod wants to merge 2 commits intodfop02:release/1.1.4from
Open
fix: restore parent ol numId after nested list closes#58arthrod wants to merge 2 commits intodfop02:release/1.1.4from
arthrod wants to merge 2 commits intodfop02:release/1.1.4from
Conversation
Refactor HTML-to-DOCX with centralized styles and test coverage
When an ordered list contains a nested list, items after the nested
list were restarting numbering at "1." instead of continuing from
the parent list's count.
The fix uses a stack (_ol_id_stack) to preserve parent list context:
- On <ol> open: push current_ol_num_id to stack before creating new one
- On <ol> close: pop from stack to restore parent's numId
Example fix:
<ol>
<li>First</li> <!-- 1. -->
<li>Second <!-- 2. -->
<ol>
<li>Second.A</li>
<li>Second.B</li>
</ol>
</li>
<li>Third</li> <!-- Now shows 3. instead of 1. -->
</ol>
Owner
|
hey @arthrod , Just a kindly reminder. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ol_id_stack) to preserve parent list context during nestingProblem
When an ordered list contains a nested list, items after the nested list were restarting numbering at "1." instead of continuing.
Example:
Root Cause
The
handle_lifunction correctly usescurrent_ol_num_idto track list continuity. However, when a nested<ol>opens,current_ol_num_idis updated to a new value. When the nested<ol>closes, the parent'scurrent_ol_num_idwas not being restored.Solution
Track
current_ol_num_idin a stack to preserve parent context:<ol>open: push current ID to stack before creating new one<ol>close: pop from stack to restore parent's IDTest plan