Open
Conversation
Contributor
Author
|
This is a bit raw, but here is the rough idea for a script which would warn when the database does not satisfy the expectation about login being case-insensitive unique: from sqlalchemy import create_engine
from sqlalchemy import text
engine = create_engine('postgresql+psycopg2://postgres:__MUST_BE_CHANGED__@127.0.0.1:5432/iris_db', echo=True)
warnings = {}
with engine.connect() as conn:
# careful the quotes matter here!!!
result = conn.execute(text('select * from "user"'))
for row in result:
login = row.user.lower()
result = conn.execute(text('select * from "user" where lower("user")=:user'), user=login)
if result.rowcount != 1:
warnings[login] = result.all()
for (lower_case_login, users) in warnings.items():
count = len(users)
print(f'WARNING: there at least {count} users with logins which are case sensitive equal to \'{lower_case_login}\':')
for user in users:
print(f'id: {user.id}, user: {user.user}, name: {user.name}') |
whikernel
approved these changes
Dec 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposition to enable case insensitive login as described in issue #252.
This change does not require any database migration, since only the retrieval of a user by its login has change. It is now done with a case insensitive query (ilike)
However this change assumes no two users were, in a previous version of DFIR-IRIS, created with logins which are the same when compared in a case insensitive way (for instance whitekernel and WhiteKernel)
Maybe, in addition to these changes, a script which checks this is the case, should be proposed in the migration note...