chore(fe): update French translations#3866
Conversation
|
@mducroux this PR may already be merged by the time you see it, but if you spot any translation mistakes feel free to leave comments or suggestions here — they'll be picked up by AI in a future run. Besides specific fixes, broader feedback is also welcome (e.g., tone, terminology preferences, style guidelines) — these will be reviewed and applied across all future translations. |
There was a problem hiding this comment.
Pull request overview
Updates the French (fr) localization catalog used by the frontend to cover additional/updated SSO-related UI messages.
Changes:
- Adds a new French translation entry for a
{domainInput}timeout message. - Replaces the SSO/domain reachability error message key and translation.
- Removes two SSO-related message entries from the French catalog.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| msgid "{domainInput} took too long to respond. Try again in a moment." | ||
| msgstr "{domainInput} a mis trop de temps à répondre. Réessayez dans un moment." | ||
|
|
There was a problem hiding this comment.
Thanks for flagging this. The msgid {domainInput} took too long to respond. Try again in a moment. does exist in the source code — it is used in src/frontend/src/lib/components/wizards/auth/views/SignInWithSso.svelte (line 103). The en.po catalog is simply behind the current source and will need a separate update via lingui extract. The fr.po entry is correct.
| msgid "Couldn't load SSO settings from {domainInput}. Ask your SSO admin to check that /.well-known/ii-openid-configuration is reachable." | ||
| msgstr "Impossible de charger les paramètres SSO depuis {domainInput}. Demandez à votre administrateur SSO de vérifier que /.well-known/ii-openid-configuration est accessible." |
There was a problem hiding this comment.
The source string itself changed in the codebase — SignInWithSso.svelte (line 106) now uses Couldn't load SSO settings from ${domainInput}. Ask your SSO admin to check that /.well-known/ii-openid-configuration is reachable. instead of the previous Couldn't reach {domainInput}. Check the spelling and your network. The old msgid no longer exists in the source, so restoring it would create an unreachable catalog entry. The fr.po correctly maps the new source string to its French translation. The en.po entry for the old string is now stale and will be cleaned up when lingui extract --clean is run.
| msgid "Session timed out" | ||
| msgstr "Session expirée" | ||
|
|
||
| msgid "Set as default sign-in" | ||
| msgstr "Définir comme connexion par défaut" | ||
|
|
||
| msgid "Several SSO sign-ins are in flight already. Wait a moment." | ||
| msgstr "Plusieurs connexions SSO sont déjà en cours. Veuillez patienter un instant." | ||
|
|
||
| msgid "Share {label}" |
There was a problem hiding this comment.
This string has been removed from the source code — a search of the frontend source confirms Several SSO sign-ins are in flight already. Wait a moment. is no longer used anywhere in src/frontend/. Removing it from fr.po is correct. The matching en.po entry is now stale and will be dropped when lingui extract --clean is run against the full repo.
| @@ -1083,9 +1083,6 @@ | |||
| msgid "To finish setting up your passkey, follow the instructions shown on your <0>new device</0>." | |||
| msgstr "Pour terminer la configuration de votre passkey, suivez les instructions affichées sur votre <0>nouvel appareil</0>." | |||
|
|
|||
There was a problem hiding this comment.
Same situation — Too many recent attempts for {domainInput}. Wait a few minutes. is no longer present in the frontend source code. The removal from fr.po is intentional and correct. The en.po entry for this string is stale and will be removed when lingui extract --clean is run.
|
Thanks for the review overview, @Copilot. The four inline concerns have been addressed in separate thread replies — the new/changed/removed msgids are all consistent with the current source strings in the frontend. |
New translations were missing for `fr`. This PR adds the missing translations.
Changes