Skip to content

chore: Bump http certification dependencies#3550

Closed
aterga wants to merge 6 commits intomainfrom
arshvair/bump-ic-certification
Closed

chore: Bump http certification dependencies#3550
aterga wants to merge 6 commits intomainfrom
arshvair/bump-ic-certification

Conversation

@aterga
Copy link
Copy Markdown
Collaborator

@aterga aterga commented Dec 19, 2025

Motivation

The latest recommended version is 3.0.3, so we should start using it. Minor breaking changes required additional attention.

Changes

  • Bump the Http certification dependencies to 3.0.3
  • Fix type errors
  • Remove obsolete streaming_strategy from the Response API (which was an optional field that has never been used by II anyway)

Tests

Existing tests should suffice.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the HTTP certification dependencies from version 2.6 to 3.0.3 and makes the necessary breaking changes to adapt to the new API. The most significant change is removing the unused streaming_strategy field from the HttpResponse type.

  • Upgraded all HTTP certification crates (ic-certification, ic-http-certification, ic-representation-independent-hash, ic-response-verification) to version 3.0.3
  • Removed the unused streaming_strategy field from HttpResponse in both the Rust interface and Candid API definitions
  • Added TryFrom implementations to convert between the local HttpRequest/HttpResponse types and the ic_http_certification library types

Reviewed changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Cargo.toml Updated workspace dependencies to version 3.0.3 for all HTTP certification crates
Cargo.lock Lock file updates reflecting the dependency version changes and transitive dependency updates (e.g., cached, darling, base64)
demos/vc_issuer/Cargo.lock Updated ic-certification version reference in demo lock file
demos/test-app/Cargo.lock Updated ic-certification version and lock file format version
src/internet_identity_interface/Cargo.toml Added ic-http-certification as a workspace dependency
src/internet_identity_interface/src/http_gateway.rs Added TryFrom implementations for converting to ic_http_certification types, removed streaming_strategy field from HttpResponse struct
src/internet_identity/internet_identity.did Removed streaming_strategy field from HttpResponse type definition
src/internet_identity/src/http.rs Removed streaming_strategy: None from all HttpResponse instantiations
src/internet_identity/tests/integration/http.rs Updated test to use try_into() conversion instead of manual field mapping
src/archive/archive.did Removed streaming_strategy field from HttpResponse type definition
src/archive/src/main.rs Removed streaming_strategy: None from all HttpResponse instantiations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/internet_identity_interface/src/http_gateway.rs Outdated
Comment thread src/internet_identity_interface/src/http_gateway.rs Outdated
Comment thread src/internet_identity_interface/src/http_gateway.rs Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/internet_identity_interface/src/http_gateway.rs Outdated
@aterga aterga marked this pull request as ready for review December 19, 2025 13:51
@aterga aterga requested a review from sea-snake December 19, 2025 13:52
@aterga
Copy link
Copy Markdown
Collaborator Author

aterga commented Mar 26, 2026

Closing this PR as stale — it has been open for ~3 months with no review activity, and the branch is behind main. If bumping the HTTP certification dependencies to v3.0.3 is still needed, a fresh PR would avoid potential merge conflicts.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants