feat: [DSM-106] Move observe_canisters_memory_usage() into background thread#10144
Open
alin-at-dfinity wants to merge 2 commits intoalin/DSM-106-observe-ReplicatedState-metrics-in-backgroundfrom
Conversation
… thread Move the logic from observe_canisters_memory_usage() into ReplicatedStateMetrics::observe(), which now runs in a background thread. Unfortunately, we still need to compute the total canister memory usage on the critical path in order to populate SubnetMetrics::canister_state_bytes, but we don't need to do that every round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the logic from
observe_canisters_memory_usage()intoReplicatedStateMetrics::observe(), which now runs in a background thread. Unfortunately, we still need to compute the total canister memory usage on the critical path in order to populateSubnetMetrics::canister_state_bytes, but we don't need to do that every round.