Skip to content

chore: use GitHub case syntax instead of ternary "if" #10139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmattia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: use GitHub case syntax instead of ternary "if" #10139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: ${{ github.event_name == 'pull_request' && 256 || 0 }}
fetch-depth: ${{ case(github.event_name == 'pull_request', 256, 0) }}
ref: ${{ inputs.commit-sha }}
- name: Filter fuzzer related files
uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:
# It also requires the AWS and CF secrets which are only available in the `upload-artifacts` environment.
# This environment is also only active on protected branches. That's why we require the `upload-artifacts` environment
# when `release-build == 'true'` but not otherwise.
name: ${{ needs.config.outputs.release-build == 'true' && 'upload-artifacts' || ''}}
name: ${{ case(needs.config.outputs.release-build == 'true', 'upload-artifacts', '') }}
runs-on: *dind-large-setup
container: *container-setup
timeout-minutes: 150
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-notify-slack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
echo "channel=${CHANNEL}" >> $GITHUB_OUTPUT
echo "message=${MESSAGE}" >> $GITHUB_OUTPUT
env:
MESSAGE: ":github: ${{ github.event.pull_request.head.repo.full_name != github.repository && ':alert: EXTERNAL PR, review extra carefully! :alert: ' || '' }}`${{ github.repository }}` <${{ github.event.pull_request.html_url }}|${{ steps.sanitize.outputs.safe_title || '' }}>"
MESSAGE: ":github: ${{ case(github.event.pull_request.head.repo.full_name != github.repository, ':alert: EXTERNAL PR, review extra carefully! :alert: ', '') }}`${{ github.repository }}` <${{ github.event.pull_request.html_url }}|${{ steps.sanitize.outputs.safe_title || '' }}>"

- name: Post to a Slack channel
if: steps.get-reviewers.outputs.result != '""' && steps.lookup.outputs.channel != 'null'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-pr-only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
with:
# Ensures we fetch the merge-base, which we compare against
fetch-depth: 0
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || inputs.commit-sha }}
ref: ${{ case(github.event_name == 'pull_request', github.event.pull_request.head.sha, inputs.commit-sha) }}
- uses: ./.github/actions/netrc
- name: Run candid compatibility checks
uses: ./.github/actions/bazel
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || inputs.commit-sha }}
ref: ${{ case(github.event_name == 'pull_request', github.event.pull_request.head.ref, inputs.commit-sha) }}
token: ${{ steps.app-token.outputs.token }}
- uses: ./.github/actions/netrc
- name: Run Linter
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-mainnet-canister-revisions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- name: Update mainnet canister versions file
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
DRY_RUN: ${{ github.event_name == 'pull_request' && '--dry-run' || '' }}
DRY_RUN: ${{ case(github.event_name == 'pull_request', '--dry-run', '') }}
run: |
set -eEuxo pipefail

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-mainnet-icos-revisions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Update mainnet ICOS versions file
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
DRY_RUN: ${{ github.event_name == 'pull_request' && '--dry-run' || '' }}
DRY_RUN: ${{ case(github.event_name == 'pull_request', '--dry-run', '') }}
run: |
set -eEuxo pipefail

Expand Down
Loading