Open
Conversation
This removes the automatic image pruning in container-run.sh and replaces it with a nudge in case the images start taking too much space. As far as I can tell, the previous pruning command would have the effect of nuking all prebuilt (and potentially reusable) layers, while at the same time ensuring that all previously built final images were kept. This means old unusable images would pile up, but intermediary layers would be nuked, leading to a lot of junk and no speedup.
nmattia
commented
May 8, 2026
| if (($images_rawsize > $MAX_GB * 10 ** 9)); then | ||
| tput -T xterm setaf 3 | ||
| tput -T xterm bold | ||
| eprintln "Container images take up more than ${MAX_GB}GB. You can reclaim space by clearing the container image cache (will cause a rebuild):" |
Contributor
Author
There was a problem hiding this comment.
it would probably make sense to print this after the container has run, otherwise users might be try to run the command from within the container
Collaborator
There was a problem hiding this comment.
Although they might not see it then anymore since after exiting your session I would expect most users to also exit their terminal soon after.
basvandijk
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the automatic image pruning in container-run.sh and replaces it with a nudge in case the images start taking too much space.
As far as I can tell, the previous pruning command would have the effect of nuking all prebuilt (and potentially reusable) layers, while at the same time ensuring that all previously built final images were kept. This means old unusable images would pile up, but intermediary layers would be nuked, leading to a lot of junk and no speedup.