Skip to content

chore: [DSM-122] Add metric for skipped optimization #10132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-weigelt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: [DSM-122] Add metric for skipped optimization #10132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions rs/state_manager/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ pub struct StateManagerMetrics {
latest_hash_tree_max_index: IntGauge,
fast_forward_height: IntGauge,
no_state_clone_count: IntCounter,
skip_optimization_missing_cert_count: IntCounter,
}

#[derive(Clone)]
Expand Down Expand Up @@ -487,6 +488,11 @@ impl StateManagerMetrics {
"Number of heights whose states were not cloned and not stored by this node.",
);

let skip_optimization_missing_cert_count = metrics_registry.int_counter(
"state_manager_skip_optimization_missing_cert_count",
"How often we could have skipped state cloning but did not because no certification was available.",
);

Self {
state_manager_error_count,
checkpoint_op_duration,
Expand Down Expand Up @@ -514,6 +520,7 @@ impl StateManagerMetrics {
latest_hash_tree_max_index,
fast_forward_height,
no_state_clone_count,
skip_optimization_missing_cert_count,
}
}

Expand Down Expand Up @@ -3417,18 +3424,23 @@ impl StateManager for StateManagerImpl {
&& !height
.get()
Copy link
Copy Markdown
Contributor Author

@michael-weigelt michael-weigelt May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line-based diff being awful. I merely put the old block inside a new if statement.

.is_multiple_of(MAX_CONSECUTIVE_ROUNDS_WITHOUT_STATE_CLONING_AND_HASHING)
&& maybe_delivered_certification.is_some()
{
#[cfg(debug_assertions)]
check_certifications_metadata_snapshots_and_states_metadata_are_consistent(&states);
if maybe_delivered_certification.is_some() {
#[cfg(debug_assertions)]
check_certifications_metadata_snapshots_and_states_metadata_are_consistent(
&states,
);

assert_tip_is_none(&states);
assert_tip_is_none(&states);

self.metrics.no_state_clone_count.inc();
self.metrics.no_state_clone_count.inc();

states.tip_height = height;
states.tip = Some(state);
return;
states.tip_height = height;
states.tip = Some(state);
return;
} else {
self.metrics.skip_optimization_missing_cert_count.inc();
}
}
maybe_delivered_certification
};
Expand Down
Loading