Skip to content

fix(etag): reject codepoints above 0xFF in ETag.parse #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koteshyelamati wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

fix(etag): reject codepoints above 0xFF in ETag.parse #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d08cbc6
fix(etag): reject codepoints above 0xFF in ETag.parse
koteshyelamati Jun 17, 2026
938f4d8
test(etag): add regression test for codepoints above 0xFF
koteshyelamati Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dexpace-sdk-core/src/dexpace/sdk/core/http/common/etag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def parse(cls, raw: str) -> Self:
# RFC 7232 §2.3: etagc = %x21 / %x23-7E / obs-text. Everything at or
# below SP (0x20) and DEL (0x7F) is outside the entity-tag character
# set; obs-text (0x80-0xFF) stays permitted.
if any(ord(ch) <= 0x20 or ord(ch) == 0x7F for ch in value):
if any(ord(ch) <= 0x20 or ord(ch) == 0x7F or ord(ch) > 0xFF for ch in value):
raise ValueError(f"Invalid ETag: illegal character in {raw!r}")
return cls(value=value, weak=weak)

Expand Down
7 changes: 7 additions & 0 deletions packages/dexpace-sdk-core/tests/http/test_etag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ def test_parse_embedded_space_raises() -> None:
ETag.parse('"a b"')


def test_parse_above_obs_text_raises() -> None:
# RFC 7232 §2.3: obs-text tops out at 0xFF; codepoints above
# that (e.g. U+20AC) are not valid entity-tag characters.
with pytest.raises(ValueError):
ETag.parse('"a€b"')


def test_parse_empty_strong_etag_raises() -> None:
with pytest.raises(ValueError, match="empty"):
ETag.parse('""')
Expand Down