fix: normalize empty reason phrase to None in asyncio transport#50
Merged
OmarAlJarrah merged 1 commit intoJun 16, 2026
Conversation
The asyncio HTTP client was reporting an empty reason phrase as an empty string instead of None, inconsistent with the requests and httpx transports which normalize empty reason phrases to None. Changed the one-liner to coerce empty string to None so that Response.reason is consistent across all adapters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45
The asyncio HTTP client reports an empty reason phrase as an empty string instead of None, which is inconsistent with the requests and httpx transports that both normalize empty reason phrases to None.
This changes the one-liner to coerce an empty reason string to None so that Response.reason is consistent across all adapters.