Apply activation before gating in MLP layer#4
Open
souvikshanku wants to merge 1 commit intodevvrit:mainfrom
Open
Apply activation before gating in MLP layer#4souvikshanku wants to merge 1 commit intodevvrit:mainfrom
souvikshanku wants to merge 1 commit intodevvrit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MLP implementation applies the activation function after the element-wise multiplication of gate and up projections, which is inconsistent with how gated activation is usually applied (e.g., see here). This fix applies the activation before multiplication which is the intended behavior.