Skip to content

Fixed gcc build errors #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
threadexio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed gcc build errors #47

threadexio wants to merge 1 commit into from

Conversation

@threadexio
Copy link

@threadexio threadexio commented Jan 16, 2022 •
edited
Loading

  • All warnings treated as errors
  • Multiple definition of int verbose

GCC version: 11.1.0

Solutions:

  • Removed the -Werror from the Makefile
  • Fixed the multiple definitions of int verbose from error.h

@threadexio
Fixed gcc build errors
82da12e 
- All warning treated as errors
- Multiple definition of "int verbose"
@Fenr1r-g
Copy link

Fenr1r-g commented Feb 14, 2022

Tested on my machine. Fixes the -werrors and successfully builds and installs sasquatch.

@Fenr1r-g Fenr1r-g mentioned this pull request Feb 17, 2022
Open
@int3rsys
Copy link

int3rsys commented Feb 20, 2022

Thank you, I've downloaded your commit and it worked contrary to the master.

This was referenced May 9, 2022
Closed
Closed
@jhilland0117
Copy link

jhilland0117 commented Jun 18, 2022 •
edited
Loading

thanks! this fixes the build for ubuntu 20+

@agoodm88
Copy link

agoodm88 commented Jun 20, 2022

Thanks, this fixes the build for me on Ubuntu 22.04

@m-1-k-3 m-1-k-3 mentioned this pull request Aug 19, 2022
Merged
@speidy
Copy link

speidy commented Sep 5, 2022

@devttys0 Please merge!

@amlamarra
Copy link

amlamarra commented Sep 18, 2022

@devttys0 Would love to get this merged.

@jacopotediosi jacopotediosi mentioned this pull request Feb 16, 2023
Closed
@jacopotediosi
Copy link

jacopotediosi commented Feb 16, 2023

Merging this PR causes some files to be lost while extracting some squashfs images (e.g., see ReFirmLabs/binwalk#618), don't know why.
On Ubuntu 22.04.1LTS I suggest to compile using #51 instead of this.

stkw0 pushed a commit to OSPG/binwalk that referenced this pull request Feb 28, 2024
@ffontaine @stkw0
deps.sh: fix sasquatch install
d588acd 
Apply devttys0/sasquatch#47 to fix build failure
with latest gcc

It should be noted that sasquatch has not been updated since March 2021

Fix ReFirmLabs#498

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bfu4 bfu4 bfu4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@threadexio @Fenr1r-g @int3rsys @jhilland0117 @agoodm88 @speidy @amlamarra @jacopotediosi @bfu4