This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Refactor library to be async first #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: spiraldancing <7736513+spiraldancing@users.noreply.github.com>
Co-authored-by: spiraldancing <7736513+spiraldancing@users.noreply.github.com>
Co-authored-by: spiraldancing <7736513+spiraldancing@users.noreply.github.com>
Co-authored-by: spiraldancing <7736513+spiraldancing@users.noreply.github.com>
tobuto
force-pushed
the
refactor/async-first
branch
from
f8b4798 to
e3d0660
Compare
tobuto
force-pushed
the
refactor/async-first
branch
from
e3d0660 to
b935b73
Compare
| <PackageTags>portable;pubsub;eventaggregator;c#</PackageTags> | ||
| <Description>An extremely light-weight, easy to use .Net pub/sub library</Description> | ||
| <Description>An extremely light-weight, easy to use .Net pub/sub library based on upta/pubsub</Description> | ||
| <Version>4.0.0</Version> |
There was a problem hiding this comment.
Originally commented here to increment the minor or major version ... then saw it is done in the next commit.
Member
Author
There was a problem hiding this comment.
Oh, I thought I had changed all version tags in the file, must have missed this one!
| {C73D1486-C5C4-4BF0-AE0B-D0A214E2CCB9}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {C73D1486-C5C4-4BF0-AE0B-D0A214E2CCB9}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {DC01D868-1B0E-4754-B070-F3CC4DAA7F7B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {DC01D868-1B0E-4754-B070-F3CC4DAA7F7B}.Debug|Any CPU.Build.0 = Debug|Any CPU |
There was a problem hiding this comment.
Doesn't the Tests Project also want a "Debug|Any CPU.ActiveCfg" setting?
Member
Author
There was a problem hiding this comment.
Good question, I rarely look into sln files, so I don't really know. But I haven't had any issues using it this way so I'd leave it like it is.
|
If this is going to be public, the README needs updating. |
mkqavi
previously approved these changes
Jul 27, 2021
vinydanylo
previously approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR