-
Notifications
You must be signed in to change notification settings - Fork 15
Review of level 1 activities #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Review of level 1 activities #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
For the assessment attribute: It was written in a way that users understand what they have to provide in order to get it marked as implemented. I do not enforce that you re-write it, but for you know.
E.g.
The organization has a process for triaging and documenting false positives and accepted risks
could be
Provide a maximum one year old sample of a false positive or accepted finding including the date, description and date and expire date
src/assets/YAML/default/CultureAndOrganization/EducationAndGuidance.yaml
Outdated
Show resolved
Hide resolved
vbakke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a thorough review.
Looks like I skipped Implementation and Test and Verification. I can try to add them soon.
However, could you please elaborate some on Default settings for intensity? The current text is very short, and I struggle to understand the boundaries for the activity.
src/assets/YAML/default/CultureAndOrganization/EducationAndGuidance.yaml
Outdated
Show resolved
Hide resolved
src/assets/YAML/default/CultureAndOrganization/EducationAndGuidance.yaml
Outdated
Show resolved
Hide resolved
…b.com/vbakke/DevSecOps-MaturityModel-data into feat/v4-review-level-1-implementation
Feat/v4 review level 1 implementation
Split 'Defined deployment process' into 'Automated deployment process'
Updated external URLs
Added tags (scannig, sca, ...)
src/assets/YAML/default/CultureAndOrganization/EducationAndGuidance.yaml
Outdated
Show resolved
Hide resolved
| Simple access control for systems: | ||
| uuid: 82e499d1-f463-4a4b-be90-68812a874af6 | ||
| risk: Attackers a gaining access to internal systems and application interfaces | ||
| measure: All internal systems are using simple authentication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wurstbrot : How do you define 'simple access control'?
Or better, can you describe to me what would not classify as simple access control?
This is a basic activity, so I presume it is any basic form for authentication? I.e. that requirering a username and password, or some form of api-key for machine-to-machine communication?
Where do we draw the line?
Added missing descriptions and assessments, on level 1 activities.
Feel free to comment and adjust. I reckon we should aim to avoid repeating the same message in multiple attributes of the same activity. But I might still be doing that. Nice with more sets of eyes to improve...