-
Notifications
You must be signed in to change notification settings - Fork 37
Add crd support #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
siaomingjeng
wants to merge
22
commits into
devopsspiral:master
Choose a base branch
from
siaomingjeng:add-crd-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add crd support #109
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7059565
Add support for custom resource definition read and list.
cb7c40e
Add test cases for CRD
f6ae6b7
Add tail newline
a3da8ac
Remove empty space
4dbf44a
test
c5e5787
Roll back fail_under setting
bc3a2a9
test
d653500
Roll back config.yml and add apis
4c9b3ad
debug
418990b
test
650ec8c
debug
11018a9
debug
faf561f
debug2
00c1eb9
remove ending blank line
724e001
new line
aeb4255
debug
7a680f0
debug
5f6d76a
debug2
f82d866
debug3
2a27b13
debug3
8abac7f
debug4
42c6199
test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| *** Settings *** | ||
| Resource ./custom_definitions_kw.robot | ||
|
|
||
| *** Variables *** | ||
| ${crds} repos.configmanagement.gke.io syncs.configmanagement.gke.io | ||
| ${crd_name} repos.configmanagement.gke.io | ||
|
|
||
| *** Test Cases *** | ||
| Check All The Custom Resource Definitions Exist | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you are missing as a result they are not executed in CI |
||
| [Documentation] Test all the given Custom Resource Definitions exist. | ||
| CRD contains: ${crds} | ||
|
|
||
| Check The Given Custom Resource Definition Exist | ||
| [Documentation] Test the given Custom Resource Definition exists. | ||
| CRD ${crd_name} exists | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| *** Settings *** | ||
| Library String | ||
| # For regular execution | ||
| Library KubeLibrary | ||
| # For incluster execution | ||
| #Library KubeLibrary None True False | ||
| # For development | ||
| #Library ../../src/KubeLibrary/KubeLibrary.py ~/.kube/k3d | ||
|
|
||
| *** Keywords *** | ||
| CRD contains: ${crd_names} | ||
| [Documentation] Check the given CRD's exist! | ||
| @{crd_name_list}= Split String ${crd_names} ${SPACE} | ||
| @{all_crds}= List Cluster Custom Definition | ||
| @{all_crd_names}= Filter Names ${all_crds} | ||
| ${crd_num}= Get Length ${all_crd_names} | ||
| Log \nTotally ${crd_num} CRD(s) have been found. console=True | ||
| FOR ${name} IN @{crd_name_list} | ||
| Should Contain ${all_crd_names} ${name} | ||
| END | ||
|
|
||
| CRD ${crd_name} exists | ||
| [Documentation] Check the given CRD exit! | ||
| ${crd_detail}= Read Cluster Custom Definition ${crd_name} | ||
| Should Be Equal ${crd_detail.kind} CustomResourceDefinition | ||
| Should Be Equal ${crd_detail.metadata.name} ${crd_name} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add mocks and perform actual check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply! Really appreciate it. Will fix it later on.