Skip to content

Literal boolean values should not be used in condition expressions #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AymanDF wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Literal boolean values should not be used in condition expressions #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/org/evilsoft/pathfinder/reference/HtmlRenderFarm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public boolean suppressTitle() {
return true;
}
HtmlRenderer prev = renderPath.get(renderPath.size() - 1);
return prev.suppressNextTitle == true;
return prev.suppressNextTitle;
}

public String renderFooter() {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/evilsoft/pathfinder/reference/SearchProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public boolean onCreate() {
}

public boolean initializeDatabase() {
if (dbWrangler != null && dbWrangler.isClosed() == false) {
if (dbWrangler != null && !dbWrangler.isClosed()) {
return true;
}
boolean cont = true;
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/evilsoft/pathfinder/reference/api/AbstractContentProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public boolean onCreate() {
}

public boolean initializeDatabase() {
if (dbWrangler != null && dbWrangler.isClosed() == false) {
if (dbWrangler != null && !dbWrangler.isClosed()) {
return true;
}
boolean cont = true;
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/evilsoft/pathfinder/reference/db/BaseDbHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ private void buildDatabase(boolean retry) throws IOException,
}
if (retry) {
boolean dbExists = checkDatabase();
if (dbExists == false) {
if (!dbExists) {
buildDatabase(false);
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/evilsoft/pathfinder/reference/db/DbWrangler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void checkDatabases() throws IOException, LimitedSpaceException {
}
checkIndexDb(current);
checkBookDbs(current);
if (current == false) {
if (!current) {
SharedPreferences.Editor editor = settings.edit();
editor.putInt(CURRENT_VERSION, VERSION);
editor.commit();
Expand Down
36 changes: 18 additions & 18 deletions app/src/main/java/org/evilsoft/pathfinder/reference/preference/FilterPreferenceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,58 +28,58 @@ public static String getSourceFilter(Context context, List<String> args,
SharedPreferences preferences = PreferenceManager
.getDefaultSharedPreferences(context);

if (preferences.getBoolean("source_APG", true) == false) {
if (!preferences.getBoolean("source_APG", true)) {
sourceList.add("Advanced Player's Guide");
}
if (preferences.getBoolean("source_ACG", true) == false) {
if (!preferences.getBoolean("source_ACG", true)) {
sourceList.add("Advanced Class Guide");
}
if (preferences.getBoolean("source_ARG", true) == false) {
if (!preferences.getBoolean("source_ARG", true)) {
sourceList.add("Advanced Race Guide");
}
if (preferences.getBoolean("source_UCA", true) == false) {
if (!preferences.getBoolean("source_UCA", true)) {
sourceList.add("Ultimate Campaign");
}
if (preferences.getBoolean("source_UC", true) == false) {
if (!preferences.getBoolean("source_UC", true)) {
sourceList.add("Ultimate Combat");
}
if (preferences.getBoolean("source_UE", true) == false) {
if (!preferences.getBoolean("source_UE", true)) {
sourceList.add("Ultimate Equipment");
}
if (preferences.getBoolean("source_UM", true) == false) {
if (!preferences.getBoolean("source_UM", true)) {
sourceList.add("Ultimate Magic");
}
if (preferences.getBoolean("source_MA", true) == false) {
if (!preferences.getBoolean("source_MA", true)) {
sourceList.add("Mythic Adventures");
}
if (preferences.getBoolean("source_OA", true) == false) {
if (!preferences.getBoolean("source_OA", true)) {
sourceList.add("Occult Adventures");
}
if (preferences.getBoolean("source_TG", true) == false) {
if (!preferences.getBoolean("source_TG", true)) {
sourceList.add("Technology Guide");
}
if (preferences.getBoolean("source_B1", true) == false) {
if (!preferences.getBoolean("source_B1", true)) {
sourceList.add("Bestiary");
}
if (preferences.getBoolean("source_B2", true) == false) {
if (!preferences.getBoolean("source_B2", true)) {
sourceList.add("Bestiary 2");
}
if (preferences.getBoolean("source_B3", true) == false) {
if (!preferences.getBoolean("source_B3", true)) {
sourceList.add("Bestiary 3");
}
if (preferences.getBoolean("source_B4", true) == false) {
if (!preferences.getBoolean("source_B4", true)) {
sourceList.add("Bestiary 4");
}
if (preferences.getBoolean("source_GMG", true) == false) {
if (!preferences.getBoolean("source_GMG", true)) {
sourceList.add("Game Mastery Guide");
}
if (preferences.getBoolean("source_PFU", true) == false) {
if (!preferences.getBoolean("source_PFU", true)) {
sourceList.add("Pathfinder Unchained");
}
if (preferences.getBoolean("source_NPC", true) == false) {
if (!preferences.getBoolean("source_NPC", true)) {
sourceList.add("NPC Codex");
}
if (preferences.getBoolean("source_MC", true) == false) {
if (!preferences.getBoolean("source_MC", true)) {
sourceList.add("Monster Codex");
}
if (sourceList.size() > 0) {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/evilsoft/pathfinder/reference/render/html/HtmlRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public String render(Cursor cursor, String newUri, int depth, boolean top,
this.alt = FullSectionAdapter.SectionUtils.getAlt(cursor);
localSetValues();
StringBuffer sb = new StringBuffer();
if (suppressTitle == false) {
if (!suppressTitle) {
sb.append(renderTitle());
}
sb.append(renderImage());
Expand Down