Feature/800 sonar mac fix#1895
Open
shodiBoy1 wants to merge 2 commits intodevonfw:mainfrom
Open
Conversation
Collaborator
Coverage Report for CI Build 25394155551Coverage decreased (-0.004%) to 70.724%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #800
Implemented changes:
Fixed infinite recursion in
Sonar.doRun()on Mac (and Linux). TheSTART/STOPcases calledsuper.run(), but sinceCommandlet.run()isfinaland dispatches todoRun()virtually, this re-enteredSonar.doRun()instead of the parent'sToolCommandlet.doRun()causing aStackOverflowErrorand exit code 255.Replaced
super.run()withsuper.doRun()in bothSTARTandSTOPbranches so the parentsrunTool(...)is invoked correctly.Verified manually on macOS:
ide sonar startnow starts SonarQube (reachable at http://localhost:9000) andide sonar stopshuts it down cleanly.Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal