Skip to content

Feature/800 sonar mac fix#1895

Open
shodiBoy1 wants to merge 2 commits intodevonfw:mainfrom
shodiBoy1:feature/800-sonar-mac-fix
Open

Feature/800 sonar mac fix#1895
shodiBoy1 wants to merge 2 commits intodevonfw:mainfrom
shodiBoy1:feature/800-sonar-mac-fix

Conversation

@shodiBoy1
Copy link
Copy Markdown
Contributor

@shodiBoy1 shodiBoy1 commented May 5, 2026

This PR fixes #800

Implemented changes:

  • Fixed infinite recursion in Sonar.doRun() on Mac (and Linux). The START/STOP cases called super.run(), but since Commandlet.run() is final and dispatches to doRun() virtually, this re-entered Sonar.doRun() instead of the parent's ToolCommandlet.doRun() causing a StackOverflowError and exit code 255.

  • Replaced super.run() with super.doRun() in both START and STOP branches so the parents runTool(...) is invoked correctly.

  • Verified manually on macOS: ide sonar start now starts SonarQube (reachable at http://localhost:9000) and ide sonar stop shuts it down cleanly.


Checklist for this PR

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 5, 2026
@shodiBoy1 shodiBoy1 self-assigned this May 5, 2026
@shodiBoy1 shodiBoy1 added macOS specific for Apple MacOS bugfix PR that fixes a bug issue labels May 5, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 25394155551

Coverage decreased (-0.004%) to 70.724%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/version/VersionSegment.java 2 89.5%

Coverage Stats

Coverage Status
Relevant Lines: 15403
Covered Lines: 11354
Line Coverage: 73.71%
Relevant Branches: 6878
Covered Branches: 4404
Branch Coverage: 64.03%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@shodiBoy1 shodiBoy1 marked this pull request as ready for review May 5, 2026 18:24
@shodiBoy1 shodiBoy1 moved this from 🆕 New to Team Review in IDEasy board May 5, 2026
@shodiBoy1 shodiBoy1 added the sonar SonarQube label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue macOS specific for Apple MacOS sonar SonarQube

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

sonar not working on Mac

2 participants