#1754: Add support for VS Code plugin versions by areinicke · Pull Request #1832 · devonfw/IDEasy

areinicke · 2026-04-17T10:05:15Z

This PR fixes #1754

Implemented changes:

VS Code extensions can now be specified with a plugin version in the extension .properties file (found under $IDE_HOME/settings/vscode/plugins/)
Example usage:

plugin_id=esbenp.prettier-vscode
plugin_active=true
tags=formatter
version=12.1.0

If the specified version is unavailable, the plugin installation will fail.

Plugins can be freely upgraded or downgraded by changing the specified version in the .properties file
Added several test cases that test the intended behavior

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

When running mvn clean test locally all tests pass and build is successful
PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
PR top-level comment summarizes what has been done and contains link to addressed issue(s)
PR and issue(s) have suitable labels
Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
You followed all coding conventions
You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
with internal

coveralls · 2026-04-17T10:10:37Z

Coverage Report for CI Build 25362807967

Coverage increased (+0.06%) to 70.716%

Details

Coverage increased (+0.06%) from the base build.
Patch coverage: No coverable lines changed in this PR.
20 coverage regressions across 5 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

20 previously-covered lines in 5 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java	9	86.29%
com/devonfw/tools/ide/tool/vscode/Vscode.java	5	80.36%
com/devonfw/tools/ide/tool/plugin/ToolPluginDescriptor.java	4	84.44%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	1	78.33%
com/devonfw/tools/ide/version/VersionSegment.java	1	90.55%

Coverage Stats


Relevant Lines:	15388
Covered Lines:	11337
Line Coverage:	73.67%
Relevant Branches:	6890
Covered Branches:	4417
Branch Coverage:	64.11%
Branches in Coverage %:	Yes
Coverage Strength:	3.12 hits per line

💛 - Coveralls

…ersions

ducminh02 · 2026-05-04T12:27:52Z

+
+    String markerFilePrefix = "plugin" + "." + getName() + "." + getInstalledEdition() + "." + plugin.name();
+    List<Path> markerFiles = fileAccess.listChildren(currentMarkerFilePath.getParent(),
+        p -> Files.isRegularFile(p) && p.getFileName().toString().startsWith(markerFilePrefix));


Great addition! However, there is a subtle edge case here with how .startsWith() matches the prefix.

If a user has two plugins installed where one plugin's name is a prefix of another (for example, java and java-extension-pack), installing or updating the shorter one (java) will accidentally delete the marker file for the longer one (java-extension-pack). This happens because "plugin.vscode.null.java-extension-pack" starts with "plugin.vscode.null.java".

To fix this and ensure we don't accidentally delete other plugins' marker files, we should check that the file name either matches the unversioned prefix exactly, or is followed specifically by the .version- delimiter.

Suggested change

p -> Files.isRegularFile(p) && p.getFileName().toString().startsWith(markerFilePrefix));

p -> {

String fileName = p.getFileName().toString();

return Files.isRegularFile(p) && (fileName.equals(markerFilePrefix)

|| fileName.startsWith(markerFilePrefix + ".version-"));

});

ducminh02 · 2026-05-04T12:30:18Z

    Properties properties = context.getFileAccess().readProperties(propertiesFile);
    String id = getString(properties, "id", "plugin_id");
    String url = getString(properties, "url", "plugin_url");
+    String version = getString(properties, "version", "plugin_version");


Users sometimes accidentally leave trailing spaces in .properties files (version=1.44.2 ), which would end up in the CLI command and the marker file.

Suggested change

String version = getString(properties, "version", "plugin_version");

String version = getString(properties, "version", "plugin_version");

if (version != null) {

version = version.trim();

}

ok, I see the issue. But this issue also affects the other fields (e.g., "id"). It would be odd to implement special handling just for this field. We could instead just trim all fields automatically in the getString() method, no? What do you think?

okay I get what you mean, it is actually better that way to be honest, with that implementation we can keep the error away from all of the fields and not only the version field

ducminh02 · 2026-05-04T12:35:10Z

-    extensionsCommands.add(plugin.id());
+    String extensionInstallTarget = plugin.id();
+    // If a version number was specified, add it to the extension identifier with the format "extensionId@version"
+    Boolean versionSpecified = (plugin.version() != null) && !plugin.version().isBlank();


It is better to use the primitive boolean here instead of the boxed Boolean object. This avoids unnecessary object overhead and eliminates the risk of a NullPointerException during unboxing, as this flag will never need to be null.

Suggested change

Boolean versionSpecified = (plugin.version() != null) && !plugin.version().isBlank();

boolean versionSpecified = (plugin.version() != null) && !plugin.version().isBlank();

ducminh02

Amazing job on this PR Alex! 🚀

The implementation is very clean and It handles the versioned plugin requirement perfectly!

I've left a few comments on some very minor adjustments and one subtle edge case regarding the marker file cleanup logic that we should address to ensure different plugins with similar names don't conflict.

…ersions

areinicke added 4 commits April 17, 2026 08:40

Inital commit. Needs testing

85fdae7

Added more descriptive LOG messages

2128b76

Reinstalling plugins with another version removes old file markers

30ab567

Comments in Test file

3c1e27e

github-project-automation Bot added this to IDEasy board Apr 17, 2026

github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 17, 2026

areinicke self-assigned this Apr 17, 2026

areinicke moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 17, 2026

areinicke added enhancement New feature or request vscode Microsoft visual studio code plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) labels Apr 17, 2026

Update Changelog

5317874

areinicke marked this pull request as ready for review April 17, 2026 10:47

areinicke moved this from 🏗 In progress to Team Review in IDEasy board Apr 17, 2026

ducminh02 self-requested a review April 17, 2026 10:59

ducminh02 self-assigned this Apr 17, 2026

Merge branch 'main' into feature/1754-Add-support-for-vscode-plugin-v…

6fdb1fa

…ersions

ducminh02 reviewed May 4, 2026

View reviewed changes

ducminh02 suggested changes May 4, 2026

View reviewed changes

areinicke added 3 commits May 4, 2026 16:43

Team Review Fixes 1

5234a52

Trim plugin fields

e160112

Merge branch 'main' into feature/1754-Add-support-for-vscode-plugin-v…

9a27bd7

…ersions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1754: Add support for VS Code plugin versions#1832

#1754: Add support for VS Code plugin versions#1832
areinicke wants to merge 9 commits intodevonfw:mainfrom
areinicke:feature/1754-Add-support-for-vscode-plugin-versions

areinicke commented Apr 17, 2026 •

edited

Loading

Uh oh!

coveralls commented Apr 17, 2026 •

edited

Loading

Uh oh!

ducminh02 May 4, 2026

Uh oh!

ducminh02 May 4, 2026

Uh oh!

areinicke May 4, 2026

Uh oh!

ducminh02 May 4, 2026

Uh oh!

ducminh02 May 4, 2026

Uh oh!

ducminh02 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-        p -> Files.isRegularFile(p) && p.getFileName().toString().startsWith(markerFilePrefix));
+     p -> {
+          String fileName = p.getFileName().toString();
+          return Files.isRegularFile(p) && (fileName.equals(markerFilePrefix)
+              || fileName.startsWith(markerFilePrefix + ".version-"));
+        });

	Boolean versionSpecified = (plugin.version() != null) && !plugin.version().isBlank();
	boolean versionSpecified = (plugin.version() != null) && !plugin.version().isBlank();

Conversation

areinicke commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR fixes #1754

Implemented changes:

Checklist for this PR

Uh oh!

coveralls commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 25362807967

Coverage increased (+0.06%) to 70.716%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

ducminh02 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ducminh02 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

areinicke May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ducminh02 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ducminh02 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ducminh02 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

areinicke commented Apr 17, 2026 •

edited

Loading

coveralls commented Apr 17, 2026 •

edited

Loading