Rust Integration by tmukh · Pull Request #1827 · devonfw/IDEasy

tmukh · 2026-04-16T09:33:06Z

This PR Fixes #1719

Updated Rust install flow to honor the explicitly requested version from CLI input (e.g. ide install rust1.1.0) instead of always resolving to the default release-0.7.
Adjusted version resolution/normalization so requested Rust versions are used consistently for artifact lookup and installation.
Improved install logging to show the effective Rust version being installed.
Added regression coverage for:
explicit version request behavior * fallback to configured default when no version is provided---

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see our DoD.

When running mvn clean test locally all tests pass and build is successful
PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
PR top-level comment summarizes what has been done and contains link to addressed issue(s)
PR and issue(s) have suitable labels- [x] Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
followed all coding conventions
added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled with internal

Checklist for tool commandletsHave you added a new `«tool»` as commandlet? There are the following additional checks:

The tool can be installed automatically (during setup via settings) or via the commandlet call
The tool is isolated in its IDEasy project, see Sandbox Principle
The new tool is added to the table of tools in LICENSE.asciidoc
The new commandlet is a command-wrapper for «tool»
Proper help texts for all supported languages are added here
The new commandlet installs potential dependencies automatically
The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue```

coveralls · 2026-04-16T09:47:47Z

Coverage Report for CI Build 24905160743

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.1%) to 70.538%

Details

Coverage decreased (-0.1%) from the base build.
Patch coverage: No coverable lines changed in this PR.
9 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

9 previously-covered lines in 2 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java	8	90.26%
com/devonfw/tools/ide/version/VersionSegment.java	1	89.24%

Coverage Stats


Relevant Lines:	15384
Covered Lines:	11316
Line Coverage:	73.56%
Relevant Branches:	6872
Covered Branches:	4383
Branch Coverage:	63.78%
Branches in Coverage %:	Yes
Coverage Strength:	3.11 hits per line

💛 - Coveralls

MarvMa

Nice work 🥳 Rust will be a nice addition to IDEasy.

MarvMa · 2026-04-17T07:33:13Z

I tried to install rust on MacOS ARM64 and got the following error message:

Trying to download rust-1.29.0.rs from https://sh.rustup.rs

Downloading 100% │██████████████████████████│ 0/0MiB (0:00:00 / 0:00:00) ?MiB/s
SHA-256 checksum 6c30b75a75b28a96fd913a037c8581b580080b6ee9b8169a3c0feb1af7fe8caf is correct.
info: downloading installer
warn: It looks like you have an existing rustup settings file at:
warn: /Users/<user>/projects/_ide/software/default/rust/rust/1.29.0/.rustup/settings.toml
warn: Rustup will install the default toolchain as specified in the settings file,
warn: instead of the one inferred from the default host triple.
info: profile set to default
info: default host triple is aarch64-apple-darwin
info: syncing channel updates for 1.29.0-aarch64-apple-darwin
info: latest update on 2018-09-13 for version 1.29.0 (aa3ca1994 2018-09-11)
error: target 'aarch64-apple-darwin' not found in channel.  Perhaps check https://doc.rust-lang.org/nightly/rustc/platform-support.html for available targets
Running command '/bin/bash' with arguments '/Users/<user>/Downloads/ide/default/rust-1.29.0.rs' '-y' '--no-modify-path' '--profile' 'default' '--default-toolchain' '1.29.0'
failed with exit code 1!
Logfile can be found at /Users/<user>/projects/_ide/logs/2026/04/17/test-project-ide-install-09-29-44.log
Running command '/bin/bash' with arguments '/Users/<user>/Downloads/ide/default/rust-1.29.0.rs' '-y' '--no-modify-path' '--profile' 'default' '--default-toolchain' '1.29.0'
failed with exit code 1!

laert-ll · 2026-04-22T06:37:03Z

I was able to install it on linux with no issues and it worked perfectly fine. Great work!

hohwille

@tmukh thanks for your PR and bringing rust support to IDEasy. 👍
Since you already left the team, my suggestions is that we merge this PR and test it after the merge when URL updater did its job.
We can then also create a cleanup issue to address my review comments.

hohwille · 2026-04-24T16:30:13Z

+  protected void performToolInstallation(ToolInstallRequest request, Path installationPath) {
+
+    VersionIdentifier resolvedVersion = request.getRequested().getResolvedVersion();
+    FileAccess fileAccess = this.context.getFileAccess();
+
+    if (Files.isDirectory(installationPath)) {
+      fileAccess.backup(installationPath);
+    }
+    fileAccess.mkdirs(installationPath);
+
+    Path cargoHome = installationPath.resolve(".cargo");
+    Path rustupHome = installationPath.resolve(".rustup");
+    fileAccess.mkdirs(cargoHome);
+    fileAccess.mkdirs(rustupHome);
+
+    Path installerScript = downloadTool(request.getRequested().getEdition().edition(), resolvedVersion);
+    if (Files.isDirectory(installerScript)) {
+      // ToolRepositoryMock may provide an unpacked folder instead of a single download file.
+      installerScript = installerScript.resolve("content.sh");
+    }
+
+    List<String> installerArgs = getRustupInstallerArgs(resolvedVersion);
+    ProcessContext process = request.getProcessContext().createChild().errorHandling(ProcessErrorHandling.THROW_CLI).directory(installationPath)
+        .withEnvVar("CARGO_HOME", cargoHome.toString()).withEnvVar("RUSTUP_HOME", rustupHome.toString());
+    if (isWindowsExeInstaller(installerScript)) {
+      Path installerExecutable = installerScript;
+      String fileName = installerScript.getFileName().toString();
+      if (!WINDOWS_RUSTUP_INIT_EXE.equalsIgnoreCase(fileName)) {
+        Path canonicalInstaller = installerScript.resolveSibling(WINDOWS_RUSTUP_INIT_EXE);
+
+        // Handle corrupted installations where rustup-init.exe might exist as a file or directory
+        if (Files.exists(canonicalInstaller, LinkOption.NOFOLLOW_LINKS)) {
+          LOG.info("Found existing installer at {}, checking type", canonicalInstaller);
+          boolean isDirectory = Files.isDirectory(canonicalInstaller, LinkOption.NOFOLLOW_LINKS);
+          LOG.info("Existing installer is {} (directory: {}), deleting it", canonicalInstaller, isDirectory);
+
+          try {
+            // First attempt: delete using fileAccess which handles files, directories, and symlinks
+            fileAccess.delete(canonicalInstaller);
+            LOG.debug("Successfully deleted existing installer at {}", canonicalInstaller);
+          } catch (IllegalStateException e) {
+            LOG.warn("First deletion attempt failed for {}, retrying: {}", canonicalInstaller, e.getMessage());
+            // Retry in case of transient lock issues
+            try {
+              fileAccess.delete(canonicalInstaller);
+              LOG.debug("Successfully deleted existing installer on retry at {}", canonicalInstaller);
+            } catch (IllegalStateException e2) {
+              LOG.error("Failed to delete {} after retry: {}", canonicalInstaller, e2.getMessage(), e2);
+              throw new IllegalStateException("Failed to clean up corrupted installer at " + canonicalInstaller
+                  + " (may be locked by another process or permission denied)", e2);
+            }
+          }
+
+          // Verify deletion was successful
+          if (Files.exists(canonicalInstaller, LinkOption.NOFOLLOW_LINKS)) {
+            boolean stillIsDirectory = Files.isDirectory(canonicalInstaller, LinkOption.NOFOLLOW_LINKS);
+            throw new IllegalStateException("Failed to delete corrupted installer at " + canonicalInstaller
+                + " (is directory: " + stillIsDirectory + ", may be locked by another process)");
+          }
+        }
+
+        fileAccess.copy(installerScript, canonicalInstaller, FileCopyMode.COPY_FILE_TO_TARGET_OVERRIDE);
+        installerExecutable = canonicalInstaller;
+      }
+      process.executable(installerExecutable).addArgs(installerArgs);
+    } else {
+      String installerScriptArg = installerScript.toAbsolutePath().toString();
+      process.executable(this.context.findBashRequired()).addArgs(installerScriptArg).addArgs(installerArgs);
+    }
+    process.run();
+
+    Path cargoBin = cargoHome.resolve("bin");
+    Path toolBin = installationPath.resolve("bin");
+    if (Files.exists(toolBin, LinkOption.NOFOLLOW_LINKS)) {
+      fileAccess.delete(toolBin);
+    }
+    if (Files.isDirectory(cargoBin)) {
+      fileAccess.symlink(cargoBin, toolBin);
+    }
+
+    this.context.writeVersionFile(resolvedVersion, installationPath);
+    LOG.debug("Installed {} in version {} at {}", this.tool, resolvedVersion, installationPath);
+  }


This looks like a lot of copy&paste from the overridden method.
IMHO it is not a good idea to implement it this way.
What if we change the logic in the super-class?
The general process with downloading, optional extraction, post-extract-hook logic, writing version file, etc. should not be duplicated.
Whenever we had such situations we added some flexibility to the super-class so we can hook into smaller special aspects in sub-class to customise what we needed.

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>

hohwille · 2026-04-24T16:45:22Z

Cant be merged cause of compile error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.9.0:compile (default-compile) on project ide-cli: Compilation failure
[ERROR] /home/runner/work/IDEasy/IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/rust/Rust.java:[62,2] error: method does not override or implement a method from a supertype

Collided with #1050.

hohwille · 2026-04-24T18:19:44Z

+
+      // Skip heavyweight MSVC installer execution in tests.
+    }
+  }


We should not do things like this but test the original commandlet.
My initial suggestion was that we add a dependencies.json and add a dependency to visual-studio-build-tools.
Then we create a VisualStudioBuildTools commandlet with that name that performs that installation on Windows and does nothing on any other OS.
Then we could even add the same dependency to GraalVM and can build native images without manually installing the VS BuildTools as currently described in https://github.com/devonfw/IDEasy/blob/main/documentation/contributing/graalvm-build-guide.adoc

tmukh added 3 commits April 16, 2026 11:27

Add Rust URL updater using rustup script

04eda6d

Add Rust commandlet installer with Windows MSVC setup

579a189

devonfw#1719: Change Rust MSVC Name

cc9b301

github-project-automation Bot added this to IDEasy board Apr 16, 2026

github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 16, 2026

tmukh self-assigned this Apr 16, 2026

tmukh requested review from MarvMa and hohwille April 16, 2026 09:33

MarvMa self-assigned this Apr 16, 2026

Added Rust commandlet properties

22bbef5

MarvMa reviewed Apr 16, 2026

View reviewed changes

Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/rust/Rust.java

MarvMa moved this from 🆕 New to Team Review in IDEasy board Apr 16, 2026

MarvMa assigned laert-ll Apr 16, 2026

laert-ll moved this from Team Review to 👀 In review in IDEasy board Apr 22, 2026

hohwille approved these changes Apr 24, 2026

View reviewed changes

hohwille added this to the release:2026.05.001 milestone Apr 24, 2026

Merge branch 'main' into 1719_Rust_Integration

45d27ba

hohwille reviewed Apr 24, 2026

View reviewed changes

Comment thread cli/src/main/resources/nls/Help_de.properties Outdated

Comment thread cli/src/main/resources/nls/Help.properties Outdated

Apply suggestions from code review

610f368

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>

hohwille added the rust label Apr 24, 2026

hohwille mentioned this pull request Apr 24, 2026

#1719: added RustUrlUpdater code from tmukh of PR #1827 #1854

Merged

7 tasks

hohwille added a commit that referenced this pull request Apr 24, 2026

#1719: added RustUrlUpdater code from tmukh of PR #1827 (#1854)

07a52da

hohwille added 2 commits April 24, 2026 20:07

Merge branch 'main' into 1719_Rust_Integration

848545c

fix installDependencies

876ec24

hohwille reviewed Apr 24, 2026

View reviewed changes

do not mock commandlet

3eb83ca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rust Integration#1827

Rust Integration#1827
tmukh wants to merge 9 commits intodevonfw:mainfrom
tmukh:1719_Rust_Integration

tmukh commented Apr 16, 2026

Uh oh!

coveralls commented Apr 16, 2026 •

edited

Loading

Uh oh!

MarvMa left a comment

Uh oh!

Uh oh!

MarvMa commented Apr 17, 2026

Uh oh!

laert-ll commented Apr 22, 2026

Uh oh!

hohwille left a comment

Uh oh!

Uh oh!

Uh oh!

hohwille Apr 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hohwille commented Apr 24, 2026

Uh oh!

hohwille Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

tmukh commented Apr 16, 2026

Checklist for this PR

Checklist for tool commandletsHave you added a new «tool» as commandlet? There are the following additional checks:

Uh oh!

coveralls commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 24905160743

Coverage decreased (-0.1%) to 70.538%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

MarvMa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MarvMa commented Apr 17, 2026

Uh oh!

laert-ll commented Apr 22, 2026

Uh oh!

hohwille left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hohwille Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hohwille commented Apr 24, 2026

Uh oh!

hohwille Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Checklist for tool commandletsHave you added a new `«tool»` as commandlet? There are the following additional checks:

coveralls commented Apr 16, 2026 •

edited

Loading