Add deterministic archive generation and checksum verification tests#1826
Open
ducminh02 wants to merge 11 commits intodevonfw:mainfrom
Open
Add deterministic archive generation and checksum verification tests#1826ducminh02 wants to merge 11 commits intodevonfw:mainfrom
ducminh02 wants to merge 11 commits intodevonfw:mainfrom
Conversation
…nd normalizing entry metadata.
Collaborator
Coverage Report for CI Build 25378019331Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.4%) to 71.041%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions241 previously-covered lines in 9 files lost coverage.
Coverage Stats
💛 - Coveralls |
satorus
reviewed
Apr 22, 2026
| fileAccess.compressZip(contentDir, out1); | ||
| } | ||
| // Wait a bit to ensure a non-deterministic time would change | ||
| Thread.sleep(1100); |
Contributor
Author
There was a problem hiding this comment.
same as in the tarGz test
…t deterministic checksum verification
…against project resources
…ts to modify file timestamps, and include .github in git tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover checksum verification in JUnit
This PR fixes #1447
Implemented changes:
Cross-Platform Archive Determinism: Fixed FileAccessImpl to ensure ZIP and TAR.GZ archives are binary-identical across OS by sorting entries and zeroing out timestamps.
Checksum Verification Tests: Added the first-time JUnit coverage for AbstractToolRepository to verify SHA-256 validation and security aborts.
Added ArchiveDeterminismTest to verify byte-for-byte reproducibility of archives.
Added ChecksumVerificationTest to verify the security gatekeeper logic (covering both matching hashes and mismatch failures).
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal