#1802 GUI State management implementation#1807
Open
laim2003 wants to merge 43 commits intodevonfw:mainfrom
Open
#1802 GUI State management implementation#1807laim2003 wants to merge 43 commits intodevonfw:mainfrom
laim2003 wants to merge 43 commits intodevonfw:mainfrom
Conversation
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
…t-for-gui' into devonfw#1785-implement-modals-in-idecontext
- Added functionality, that selecting a different project now switches the IdeContext to the new project.
…plementation' into devonfw#1802-state-management-implementation
…r other ui feature branches
laim2003
added
GUI
- added DI for IdeGuiStateManager.switchContext
Collaborator
Coverage Report for CI Build 25366019060Coverage increased (+0.03%) to 70.684%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions32 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
…reading the list of workspaces/projects instead of reading those from the UI
laim2003
added
the
internal
…nager, when switchContext(Path rootDirectory, ...) is called.
This reverts commit 6f92d93.
…plementation' into devonfw#1802-state-management-implementation
…tateManager is now set when calling getInstance(), allowing us to provide a getInstance() method with a DI parameter
… getInstance()) (see previous commit)
…can be extended by tests
…plementation' into devonfw#1802-state-management-implementation
…eGuiStateManager;
…IdeGuiStateManager
- not automatically select a workspace - to seperate concerns of which functions update the workspace combobox and which the project combobox
…low new Select-Project-Then-Select-Workspace UI logic (previous commit)
laim2003
force-pushed
the
#1802-state-management-implementation
branch
from
459f762 to
6c44432
Compare
…of own implementation
…plementation' into devonfw#1802-state-management-implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1802
Implemented changes:
Main points:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal