Skip to content

#1775: validate and update CPE vendor and product for all tools#1796

Open
MarvMa wants to merge 1221 commits intodevonfw:mainfrom
MarvMa:bugfix/#1775-validate-cve-reportings
Open

#1775: validate and update CPE vendor and product for all tools#1796
MarvMa wants to merge 1221 commits intodevonfw:mainfrom
MarvMa:bugfix/#1775-validate-cve-reportings

Conversation

@MarvMa
Copy link
Copy Markdown
Contributor

@MarvMa MarvMa commented Apr 2, 2026

This PR fixes #1775

Implemented changes:

  • updated cpe's for all products
  • removed cpe-vendor and cpe-product for tools where no cpe entry exists on nvd
  • created a shell-script to verify cpe data using a POST request with search params. (doesn't work for all the CPEs, some needed a manual check)
    collect-cpe-report.sh
  • Added the possibility to add several CPE vendors and products
  • Added a documentation for contributers which explains how to use the overwriteable Method initCpe

How to test the functionality

  1. Run the BuildSecurityJsonFiles with the path to the ide-urls as an argument (Running this command for the first time can take some time to download the CVEdb)
  2. Check if the run is successful and all the security.json files are beeing created as expected

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

jan-vcapgemini and others added 30 commits October 23, 2025 12:21
…ess. (devonfw#1542)

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Removed duplicate entry for issue devonfw#1549 from changelog.
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Fixes devonfw#1581

- Extracted findIdeHome() as protected method in AbstractIdeContext returning Map.Entry<Path, String>
- Made isIdeHome() protected to allow access in test contexts
- Overridden findIdeHome() in AbstractIdeTestContext to enforce test boundaries
- Added findTestProjectRoot() to locate test resource boundaries via src/test/resources/ide-projects marker
- Set ide.test.root.boundary system property to prevent upward traversal beyond test scope
- Validated detected IDE home stays within test boundaries with clear error messages
- All 80 tests pass successfully with no failures or errors
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…w#1557)

Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: jan-vcapgemini <jan-vincent.hoelzle@capgemini.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
)

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
jakozian and others added 19 commits April 17, 2026 13:41
Co-authored-by: MarvMa <marvin.meitzner@gmail.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…com:MarvMa/IDEasy into bugfix/devonfw#1775-validate-cve-reportings
…com:MarvMa/IDEasy into bugfix/devonfw#1775-validate-cve-reportings
…com:MarvMa/IDEasy into bugfix/devonfw#1775-validate-cve-reportings
@MarvMa MarvMa moved this from 🏗 In progress to Team Review in IDEasy board Apr 24, 2026
@MarvMa MarvMa marked this pull request as ready for review April 24, 2026 12:29
protected void initCpe(CpeRegistry cpe) {
cpe.addVendor("oracle")
.addProduct("jdk")
.addProduct("java_se");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm previously we checked eclipse temurin as vendor+product...why do we now use oracle ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! I changed the CPEs for testing purposes, but your totally right. I will rollback to the previous implementation.

@satorus
Copy link
Copy Markdown
Contributor

satorus commented Apr 28, 2026

Looks good so far, the security.json files are being built and look correct as far as i can see. The only question left is why we switched the vendor to Oracle from Eclipse in the java updater (see comment). But this is only a minor point, I think the PR is ready

@github-project-automation github-project-automation Bot moved this from Team Review to 👀 In review in IDEasy board Apr 28, 2026
@KarimALotfy KarimALotfy moved this from 👀 In review to 🆕 New in IDEasy board May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security CVEs or other vulnerabilities workflow GitHub actions (CI,CD,update urls/CVEs)

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

Validate and Fix CPE Vendor/Product Identifiers for All Tools