Skip to content

Conversation

@hohwille
Copy link
Member

@hohwille hohwille commented Jan 20, 2026

This PR fixes an NPE

that was reported in #1683 but the issue itself is about something else.

Implemented changes:

  • fix NPE: make backup work also if IDE_HOME is undefined.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille added this to the release:2026.01.001 milestone Jan 20, 2026
@hohwille hohwille self-assigned this Jan 20, 2026
@hohwille hohwille added bugfix PR that fixes a bug issue core FileAccess, ProcessUtil, IdeContext, etc. internal Nothing to be added to CHANGELOG, only internal story labels Jan 20, 2026
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jan 20, 2026
@hohwille hohwille merged commit 87b1f4e into devonfw:main Jan 20, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in IDEasy board Jan 20, 2026
@hohwille hohwille deleted the feature/1683-fix-npe branch January 20, 2026 17:39
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 21181339274

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 151 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 70.454%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/io/FileAccessImpl.java 151 67.4%
Totals Coverage Status
Change from base Build 21177469615: -0.003%
Covered Lines: 10482
Relevant Lines: 14292

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue core FileAccess, ProcessUtil, IdeContext, etc. internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants